Skip to content

roachtest: remove error assertion from panic node mutator #148596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025
Merged

roachtest: remove error assertion from panic node mutator #148596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions pkg/cmd/roachtest/roachtestutil/mixedversion/steps.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (
"fmt"
"math"
"math/rand"
"regexp"
"strings"
"time"

Expand Down Expand Up @@ -804,8 +803,6 @@ func (s panicNodeStep) Description() string {
return fmt.Sprintf("panicking system interface on node %d", s.targetNode[0])
}

var connectionRefusedRegex = regexp.MustCompile(`dial tcp .*: connect: connection refused`)

func (s panicNodeStep) Run(ctx context.Context, l *logger.Logger, rng *rand.Rand, h *Helper) error {
nodeVersion, err := h.System.NodeVersion(s.targetNode[0])
if err != nil {
Expand All @@ -831,14 +828,6 @@ func (s panicNodeStep) Run(ctx context.Context, l *logger.Logger, rng *rand.Rand
return errors.Errorf("expected panic statement to fail, but it succeeded on %s", s.targetNode)
}

isTCPError := connectionRefusedRegex.MatchString(err.Error())

// The expected behavior is that the panic statement will fail with a TCP connection error,
// so any other error is unexpected and should cause the test to fail.
if !isTCPError {
return errors.Wrapf(err, "unexpected error when executing panic statement on %s", s.targetNode)
}

startCtx, cancel := context.WithTimeout(ctx, startTimeout)
defer cancel()

Expand Down