libroach: ensure encryption flags are passed if previously used. #28710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
29 tasks
Add some safeguards around the encryption flag. When we have a `COCKROACH_REGISTRY` file, we absolutely must keep using it to keep track of all files. It gets created the first time a file is created when using the file_registry which currently only happens when `--enterprise-encryption` is specified. This means that if we have a registry file, we MUST have encryption options (and be using a CCL build). Also add a simple interactive test to check encryption transition and handling of some bad args (wrong keys, no encryption flag) Release note: None
mberhault
force-pushed
the
marc/ensure_encryption_flags
branch
from
92a85f0 to
fda5612
Compare
bdarnell
approved these changes
Aug 16, 2018
Contributor
bdarnell
left a comment
bdarnell
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
Contributor
Author
|
bors r+ |
Contributor
Build failed |
Contributor
Author
|
bors retry |
Contributor
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 16, 2018
28710: libroach: ensure encryption flags are passed if previously used. r=mberhault a=mberhault Add some safeguards around the encryption flag. When we have a `COCKROACH_REGISTRY` file, we absolutely must keep using it to keep track of all files. It gets created the first time a file is created when using the file_registry which currently only happens when `--enterprise-encryption` is specified. This means that if we have a registry file, we MUST have encryption options (and be using a CCL build). Also add a simple interactive test to check encryption transition and handling of some bad args (wrong keys, no encryption flag) Release note: None Co-authored-by: marc <marc@cockroachlabs.com>
Contributor
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some safeguards around the encryption flag.
When we have a
COCKROACH_REGISTRYfile, we absolutely must keep usingit to keep track of all files.
It gets created the first time a file is created when using the
file_registry which currently only happens when
--enterprise-encryptionis specified.This means that if we have a registry file, we MUST have encryption
options (and be using a CCL build).
Also add a simple interactive test to check encryption transition and
handling of some bad args (wrong keys, no encryption flag)
Release note: None