roachtest: add a retry loop around network activity #31508
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained
pkg/cmd/roachtest/hibernate.go, line 108 at r1 (raw file):
// Build hibernate, this step involves some downloading, so it gets added // to the retry loop.
Starting the retry loop from scratch at this point seems unfortunate. The earlier parts seem reasonable to keep in the same loop, but I'm thinking this should be pulled out to a separate loop.
BramGruneir
force-pushed
the
hibernate-redux
branch
from
4e5d558 to
27b0d93
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/hibernate.go, line 108 at r1 (raw file):
Previously, petermattis (Peter Mattis) wrote…
Starting the retry loop from scratch at this point seems unfortunate. The earlier parts seem reasonable to keep in the same loop, but I'm thinking this should be pulled out to a separate loop.
Done.
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/hibernate.go, line 111 at r2 (raw file):
t.Status("building hibernate (without tests)") attempt = 0 for r := retry.StartWithCtx(ctx, opts); r.Next(); {
I believe this can be for attempt, r := 0, retry.StartWithCtx(...); r.Next(); { ... }. Ditto for the loop above.
BramGruneir
force-pushed
the
hibernate-redux
branch
from
27b0d93 to
51845a9
Compare
This is a first attempt to try to address cockroachdb#31127 and cockroachdb#31298 by putting a retry loop around anything that does any downloading. We've seen a number of flakes because of iffy networking and this should hopefully solve the problem. If this doesn't fix the issues, the next step it to add some alternative sources to sources.list.d. Release note: None
BramGruneir
force-pushed
the
hibernate-redux
branch
from
51845a9 to
a0115e6
Compare
|
bors r+ |
31508: roachtest: add a retry loop around network activity r=BramGruneir a=BramGruneir This is a first attempt to try to address #31127 and #31298 by putting a retry loop around anything that does any downloading. We've seen a number of flakes because of iffy networking and this should hopefully solve the problem. If this doesn't fix the issues, the next step it to add some alternative sources to sources.list.d. Release note: None Co-authored-by: Bram Gruneir <bram@cockroachlabs.com>
There was a problem hiding this comment.
TFTR!
Reviewable status:
pkg/cmd/roachtest/hibernate.go, line 111 at r2 (raw file):
Previously, petermattis (Peter Mattis) wrote…
I believe this can be
for attempt, r := 0, retry.StartWithCtx(...); r.Next(); { ... }. Ditto for the loop above.
Yep. Done.
Build succeeded |
This is a first attempt to try to address #31127 and #31298 by putting a retry
loop around anything that does any downloading. We've seen a number of flakes
because of iffy networking and this should hopefully solve the problem.
If this doesn't fix the issues, the next step it to add some alternative
sources to sources.list.d.
Release note: None