workload/tpcc: split, partition, and scatter during initialization #33242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
nvb
force-pushed
the
nvanbenschoten/fixChaosTpcc
branch
2 times, most recently
from
66f09fe to
5fc83fc
Compare
danhhz
approved these changes
Dec 26, 2018
nvb
force-pushed
the
nvanbenschoten/fixChaosTpcc
branch
2 times, most recently
from
3192e4b to
a67edac
Compare
Release note: None
nvb
force-pushed
the
nvanbenschoten/fixChaosTpcc
branch
from
a67edac to
4e135d4
Compare
This commit pushes this logic into tpcc's `PostLoad` hook, where it belongs. Release note: None
Release note: None
nvb
force-pushed
the
nvanbenschoten/fixChaosTpcc
branch
from
4e135d4 to
8876c27
Compare
Contributor
Author
|
bors r+ |
Contributor
Build failed (retrying...) |
Contributor
Build failed |
Contributor
Author
|
Acceptance flake: #35326. bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 9, 2019
33242: workload/tpcc: split, partition, and scatter during initialization r=nvanbenschoten a=nvanbenschoten Fixes #32135. This PR pushes splitting, partitioning, and scattering logic into `tpcc`'s `PostLoad` hook, removing it from its `Ops` method. Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Contributor
Build succeeded |
nvb
added a commit
to nvb/cockroach
that referenced
this pull request
Apr 14, 2019
Fixes cockroachdb#36776. This was broken by cockroachdb#33242. I'd rather not allow this, but doing so breaks compatibility with a lot of our guides. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Apr 14, 2019
36778: workload/tpcc: reallow scattering during `workload run` r=nvanbenschoten a=nvanbenschoten Fixes #36776. This was broken by #33242. I'd rather not allow this, but doing so breaks compatibility with a lot of our guides. Release note: None Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32135.
This PR pushes splitting, partitioning, and scattering logic into
tpcc'sPostLoadhook, removing it from itsOpsmethod.