opt: add volatility info for Unknown to Tuple cast #50436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rohany
approved these changes
Jun 19, 2020
RaduBerinde
force-pushed
the
fix-volatility-crash
branch
from
ae82cfc
to
5699651
Compare
|
TFTR! Added a test. |
|
bors r+ |
|
bors r- |
Canceled |
Casts from Unknown to any type are allowed as a special case, but we had no cast defined from Unknown to Tuple (leading to an assertion error). This change adds this missing information. I checked that now all type families define a cast from Unknown. Fixes cockroachdb#50258. Release note (bug fix): fix recently introduced "no volatility for cast unknown::tuple" error.
RaduBerinde
force-pushed
the
fix-volatility-crash
branch
from
5699651
to
2b7cab1
Compare
|
bors r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Casts from Unknown to any type are allowed as a special case, but we had no cast
defined from Unknown to Tuple (leading to an assertion error). This change adds
this missing information. I checked that now all type families define a cast
from Unknown.
Fixes #50258.
Release note (bug fix): fix recently introduced "no volatility for cast
unknown::tuple" error.