Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-20.2: kvserver: sync cluster version setting to store #55501

Closed
wants to merge 1 commit into from

Conversation

tbg
Copy link
Member

@tbg tbg commented Oct 13, 2020

Backport 1/1 commits from #55240.

/cc @cockroachdb/release

Fixes #54908.


Writes to a storage.Engine are not sync'ed by default, meaning that
they can get lost due to an ill-timed crash.

Fixes #54906.

(The backport will take care of #54908).

Release note (bug fix): a rare scenario in which a node would refuse
to start after updating the binary was fixed. The log message would
indicate: "store [...], last used with cockroach version [...], is too
old for running version [...] (which requires data from [...] or
later)".

Writes to a RocksDB `storage.Engine` were not sync'ed by default,
meaning that they can get lost due to an ill-timed crash. They are now,
matching pebble's behavior. This affects only WriteClusterVersion,
updateBootstrapInfoLocked, WriteLastUpTimestamp, and Compactor.Suggest,
nonw of which are performance sensitive.

Fixes cockroachdb#54906.

(The backport will take care of cockroachdb#54908).

Release note (bug fix): a rare scenario in which a node would refuse
to start after updating the binary was fixed. The log message would
indicate: "store [...], last used with cockroach version [...], is too
old for running version [...] (which requires data from [...] or
later)".
@tbg tbg requested a review from petermattis October 13, 2020 14:07
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @petermattis)

@tbg
Copy link
Member Author

tbg commented Oct 14, 2020

Got a flake on TestLogic/fakedist/schema/user_schema_search_path. Don't see an issue about it. @jordanlewis know anything about this?

 --- FAIL: TestLogic/fakedist/schema/user_schema_search_path (0.84s)
                logic.go:2112: 
                     
                    testdata/logic_test/schema:538: SELECT
                      database_name, parent_id, schema_name, parent_schema_id, name, table_id
                    FROM crdb_internal.tables
                    WHERE database_name IN ('test', 'new_db')
                    expected:
                        test    52   myschema2    54   tb                55
                        test    52   myschema2    54   v                 58
                        test    52   myschema2    54   s                 59
                        test    52   myschema2    54   tb2               60
                        test    52   [62]         62   myschema_t1       64
                        test    52   [62]         62   myschema_t2       65
                        test    52   [62]         62   myschema_seq1     66
                        test    52   [62]         62   myschema_t3       67
                        test    52   otherschema  70   otherschema_v1    71
                        test    52   otherschema  70   otherschema_t1    72
                        test    52   otherschema  70   otherschema_seq1  73
                        test    52   [75]         75   scdrop1_t1        78
                        test    52   [75]         75   scdrop1_t2        79
                        test    52   [76]         76   scdrop2_t1        80
                        test    52   [76]         76   scdrop2_v1        81
                        test    52   [77]         77   scdrop3_v1        82
                        test    52   privs        90   tbl               93
                        test    52   privs        90   usage_tbl         96
                        new_db  103  [104]        104  bar               105
                        new_db  103  public       29   public_table      107
                        new_db  103  testuser     106  test_table        108
                        new_db  103  public       29   test_table        109
                    but found (query options: "rowsort" -> ignore the following ordering of rows) :
                        test    52   myschema2    54   tb                55
                        test    52   myschema2    54   v                 58
                        test    52   myschema2    54   s                 59
                        test    52   myschema2    54   tb2               60
                        test    52   [62]         62   myschema_t1       64
                        test    52   [62]         62   myschema_t2       65
                        test    52   [62]         62   myschema_seq1     66
                        test    52   [62]         62   myschema_t3       68
                        test    52   otherschema  71   otherschema_v1    72
                        test    52   otherschema  71   otherschema_t1    73
                        test    52   otherschema  71   otherschema_seq1  74
                        test    52   [76]         76   scdrop1_t1        79
                        test    52   [76]         76   scdrop1_t2        80
                        test    52   [77]         77   scdrop2_t1        81
                        test    52   [77]         77   scdrop2_v1        82
                        test    52   [78]         78   scdrop3_v1        83
                        test    52   privs        91   tbl               94
                        test    52   privs        91   usage_tbl         97
                        new_db  104  [105]        105  bar               106
                        new_db  104  public       29   public_table      108
                        new_db  104  testuser     107  test_table        109
                        new_db  104  public       29   test_table        110

@tbg
Copy link
Member Author

tbg commented Nov 3, 2020

#55745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants