sql: remove fake index and statistics collectors pg_catalog tables #61794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
RichardJCai
force-pushed
the
remove_index_and_stat_collector_tables_03102021
branch
3 times, most recently
from
3d0108c
to
78f16a7
Compare
rafiss
requested changes
Mar 11, 2021
mnovelodou
reviewed
Mar 11, 2021
There was a problem hiding this comment.
I created the following issue and assigned it to myself:
#61860
Reviewable status:
complete! 0 of 0 LGTMs obtained
rafiss
approved these changes
Mar 11, 2021
Release note (sql change): Remove pg_catalog tables that were mistakenly added, notably all tables that end in _index that are not pg_catalog.pg_classes and all statistics collector tables that are not pg_stat_activity.
RichardJCai
force-pushed
the
remove_index_and_stat_collector_tables_03102021
branch
from
78f16a7
to
9fff967
Compare
|
TFTR |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note (sql change): Remove pg_catalog tables that were mistakenly added,
notably all tables that end in _index that are not pg_catalog.pg_classes and all
statistics collector tables that are not pg_stat_activity.
Removing pg statistics collector tables since they are somewhat different from regular pg_catalog tables and it's unlikely for us to implement them. Accessing them will simply error.
pg_metadata_test.gohas not yet been updating to reflect that the _index tables should not actually be tables.