Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: set crdb_test, crdb_test_off build tags appropriately #62468

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

rickystewart
Copy link
Collaborator

@rickystewart rickystewart commented Mar 23, 2021

Fixes #61724

Release note: None

@rickystewart rickystewart requested a review from rail March 23, 2021 16:58
@rickystewart rickystewart requested a review from a team as a code owner March 23, 2021 16:58
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rickystewart rickystewart removed the request for review from a team March 23, 2021 16:59
Copy link
Member

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rail)

Copy link
Member

@rail rail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rickystewart)

@rickystewart
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 23, 2021

Build succeeded:

@craig craig bot merged commit 35a64c6 into cockroachdb:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bazel: figure out support for crdb_test, crdb_test_off tags within Bazel build
4 participants