Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: Disable read sampling and read compactions #66152

Merged
merged 1 commit into from
Jun 8, 2021
Merged

storage: Disable read sampling and read compactions #66152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/storage/pebble.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,13 @@ func DefaultPebbleOptions() *pebble.Options {
// SSDs, that kick off an expensive GC if a lot of files are deleted at
// once.
opts.Experimental.MinDeletionRate = 128 << 20 // 128 MB
// Disable read sampling and by extension read-triggered compactions. Read-
// triggered compactions are known to cause excessively high write
// amplification on some read heavy workloads. See:
// https://github.com/cockroachdb/pebble/issues/1143
//
// TODO(bilal): Remove this line when the above issue is addressed.
opts.Experimental.ReadSamplingMultiplier = -1

for i := 0; i < len(opts.Levels); i++ {
l := &opts.Levels[i]
Expand Down