options: enable read based compactions #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
itsbilal
reviewed
Dec 22, 2020
There was a problem hiding this comment.
Think there should be two more changes:
if samplingPeriod <= 0 { return }in iterator.go- Change comment in options.go to say that a negative value disables read sampling.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aadityasondhi)
This change enables read based compactions by default and sets the read sampling threshold. This is based on the findings in cockroachdb#29.
aadityasondhi
force-pushed
the
aaditya/enable-read-compaction
branch
from
3ebb387
to
249de1f
Compare
aadityasondhi
commented
Dec 22, 2020
There was a problem hiding this comment.
TFTR! Made the changes.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @itsbilal)
itsbilal
approved these changes
Dec 22, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:
This was referenced Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables read based compactions by default and sets the read
sampling threshold. This is based on the findings in
#29.