From c576ad0b1c0d11563f8fd75aefc5cab80dea31ea Mon Sep 17 00:00:00 2001 From: cocoa-dev006 <93573337+cocoa-dev006@users.noreply.github.com> Date: Fri, 16 Sep 2022 16:01:42 +0900 Subject: [PATCH] registerAPI always return 200 --- src/Covid19Radar.Api.Tests/RegisterApiTest.cs | 8 ++++---- src/Covid19Radar.Api/RegisterApi.cs | 9 ++------- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/src/Covid19Radar.Api.Tests/RegisterApiTest.cs b/src/Covid19Radar.Api.Tests/RegisterApiTest.cs index 2e3a40201..4aae89430 100644 --- a/src/Covid19Radar.Api.Tests/RegisterApiTest.cs +++ b/src/Covid19Radar.Api.Tests/RegisterApiTest.cs @@ -29,7 +29,7 @@ public void CreateMethod() } [TestMethod] - public async Task RunAsyncMethod() + public void RunAsyncMethod() { // preparation var userRepo = new Mock(); @@ -48,12 +48,12 @@ public async Task RunAsyncMethod() config.Setup(_ => _["AzureFrontDoorId"]).Returns("3a1f9e76-f8c9-4000-b4e0-9bb08abe9fe5"); // action - await registerApi.RunAsync(context.Object.Request); + registerApi.RunAsync(context.Object.Request); // assert } [TestMethod] - public async Task RunAsyncMethodOnErrorValidationServer() + public void RunAsyncMethodOnErrorValidationServer() { // preparation var userRepo = new Mock(); @@ -66,7 +66,7 @@ public async Task RunAsyncMethodOnErrorValidationServer() var context = new Mock(); // action - var result = await registerApi.RunAsync(context.Object.Request); + var result = registerApi.RunAsync(context.Object.Request); // assert Assert.AreEqual(IValidationServerService.ValidateResult.Error.ErrorActionResult, result); } diff --git a/src/Covid19Radar.Api/RegisterApi.cs b/src/Covid19Radar.Api/RegisterApi.cs index d9810bcb0..e309622f6 100644 --- a/src/Covid19Radar.Api/RegisterApi.cs +++ b/src/Covid19Radar.Api/RegisterApi.cs @@ -38,7 +38,7 @@ public RegisterApi( } [FunctionName(nameof(RegisterApi))] - public async Task RunAsync( + public IActionResult RunAsync( [HttpTrigger(AuthorizationLevel.Function, "post", Route = "register")] HttpRequest req) { Logger.LogInformation("C# HTTP trigger function processed a request."); @@ -50,12 +50,7 @@ public async Task RunAsync( return validateResult.ErrorActionResult; } - // UserUuid - var userUuid = Guid.NewGuid().ToString("N") - + DateTime.UtcNow.Ticks.ToString(); - - // save to DB - return await Register(userUuid); + return new OkResult(); } private async Task Register(string userUuid)