Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggle Cards shortcut not working #1845

Closed
lucassperez opened this issue Nov 21, 2023 · 15 comments
Closed

Toggle Cards shortcut not working #1845

lucassperez opened this issue Nov 21, 2023 · 15 comments
Labels
Completion / Revision Rethink, complete, improve, tweak our feature or structure. Exemplary! worth reading & repeating. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. UI (UX) about our UI (UX) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Milestone
Little or easy

Comments

@lucassperez
Copy link

Bug Report:

  • BUG: The shortcut to toggle cards don't seem to be working
  • HOW: Set a shortcut to toggle cards, wait for cards to appear (like at the end of videos), use the shortcut and the cards don't disappear ):
  • I'm running version 4.408 of this plugin (installed today, in fact) and Firefox version 119.0.1 on a Linux machine (Fedora 37)

I'm not sure I follow the instructions to help the debugging, do you want the whole html of the page or just the html tag? I'm pasting here the html tag, but if you need everything, please let me know. It is humongous though. I disabled every extension I have but this one, opened a video with cards at the end in incognito mode and tried the shortcuts I tried. No error message appeared in the console as far as I could tell.

<html style="font-size: 10px;font-family: Roboto, Arial, sans-serif;" lang="en-GB" darker-dark-theme=""
  darker-dark-theme-deprecate="" system-icons="" typography="" typography-spacing="" it-pathname="/watch"
  it-add-scroll-to-top="true" it-below-player-pip="false" it-default-content-country="GB" it-open-new-tab="true"
  it-player-autoplay="false" it-popup-window-buttons="true" it-shortcut-toggle-cards="[object Object]"
  it-theme="undefined" it-up-next-autoplay="false" data-page-type="video" data-system-color-scheme="light">

With recent youtube changes, the plugin I used to use, Enhancer for YouTube, has temporarily stopped distributing and became a little buggy, so I searched for a new one. That extension had a hide cards shortcut that still worked though.

More / optionally:

  • Browser: Firefox 119.0.1
  • Settings: improvedtube.json
  • OS: Fedora Linux 37
  • Device: A Samsung Laptop, dunno
@lucassperez lucassperez added Bug Bug or required update after YouTube changes good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥ labels Nov 21, 2023
@ImprovedTube ImprovedTube added the Exemplary! worth reading & repeating. label Nov 21, 2023
@ImprovedTube
Copy link
Member

hi @lucassperez! thanks for caring. i guess that means these features also don't work for you?
youtube cards

The bug template was recently edited and you are the first one to try it. While you might noticed our CSS features are organized by the attributes in the html tag, the template meant the whole DOM to track more of the different YouTube versions and be able to fix some bugs without reproducing them*. Also it seemed easier than telling users(some who just sign up on GitHub because of us) to find the element(such as cards) per right-click: inspect, even though devTools picker markup/sync is nice🤔.

(*if it still works in YouTube enhancer these days, that should also be enough of a clue.)

@ImprovedTube
Copy link
Member

btw @PG-257811 this should work quick/efficient enough just i case you wanna see our shortcuts structure too (not meeting many repeat-contributors yet)

@pg2511
Copy link
Member

pg2511 commented Nov 21, 2023

Yeah for sure, I will look into it @ImprovedTube

@pg2511
Copy link
Member

pg2511 commented Nov 21, 2023 •
edited
Loading

Hello @lucassperez,

Please have a look at below video:
Toggle Cards.webm
- Is this the thing you are trying to convey to us?

Feel free to tell any suggestions you have.
Thanks for pointing out the issue.

@pg2511 pg2511 mentioned this issue Nov 21, 2023
Closed
@lucassperez
Copy link
Author

Hi, guys! Sorry, only got out of work now. Thanks for all the replies!

First thing, the options to always hide cards and make them appear do work here. Only the shortcut version that do not seem to be working, if I understood the functionality correctly.

Second thing, the cards that I thought would be hidden are the ones shown during the video but close to the end, and not the suggested videos after the video has already ended, @PG-257811. Like these:

image

I might have misunderstood the functionality? But the suggested videos after the end don't seem to disappear with the options shown by @ImprovedTube in the first comment, only the one in the image above.

These I can never make disappear:

image

@pg2511
Copy link
Member

pg2511 commented Nov 22, 2023

Thanks @lucassperez, for mentioning out more precisely.

@ImprovedTube ImprovedTube added the UI (UX) about our UI (UX) label Nov 22, 2023
@ImprovedTube
Copy link
Member

ImprovedTube commented Nov 22, 2023 •
edited
Loading

hi! sorry i misassumed we might need an update.

  • the issue are the names for these things (endscreen? (end-)cards?)
    endscreen end-cards
    • we didn't provide a shortcut yet to hide the end-screen because people might want to hide it permanently rather. (Why) do you want a shortcut for either? @lucassperez

Shortcuts

Please have a look at below video:
Toggle Cards.webm

#1846 was fine! @PG-257811
we can keep the line:

document.documentElement.toggleAttribute('it-player-hide-cards');

and add* another: document.documentElement.toggleAttribute('it-player-endscreen');
since the code is prepared

Structure & UI:

  • ...*Should we rename (refine) the shortcut as Toogle endscreen & cards ? (@lucassperez) - or even sum up further: "toogle player controls, endscreen & cards?"

    • Who could ever want separate shortcuts for these things / why? (While we can provide every shortcut one by one and leave it up to the user to set the same one for groups maybe, thats to much to expect from most users and might just be complication.)

  • We have 30+ options hiding something on youtube so they could be grouped, etc. ...
    About structure: STRUCTURE: Tooltips; extra Tags/keywords; Menu sections; Search; Documentation [PLEASE BRAINSTORM] #748

@ImprovedTube ImprovedTube added the Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. label Nov 22, 2023
@pg2511
Copy link
Member

pg2511 commented Nov 22, 2023

Hello @ImprovedTube,
The line before it-player-hide-cards does not seem to be working for me when i tried.

I have then modified the code and below is the result of it: (please have a look)
This is done when user press shortcut attached to -> toggle cards

toggle.cards.shortcut.webm

If it looks fine to you, then I will raise a PR for the same, or else you can share your thoughts.

@ImprovedTube
Copy link
Member

yes, as it is two things (sorry :D)

@lucassperez
Copy link
Author

Well, as to why I want the hability to hide/unhide those cards on demand is probably because I don't hate those cards. Sometimes they show things I'm interested in, but sometimes they also block something visual in the video, and I usually just hide them when this happens.

I'm talking about the cards that appear before the video ends but when it gets close to the end.

There are channels that make the last seconds of the video just a black screen or an ending screen exactly to accomodate these cards, but there are some that do not, and in those cases sometimes they block something and I feel like hiding them.

And about the end screen cards with a bunch of suggested videos, I really don't mind it and never had the urge to hide it and probably don't need a shortcut for that. Probably the end screen cards are more of a "hide it always" or "never hide" type of thing.

Now, I agree that having way too much options is not a good experience for the users, so simplicity is a good thing, but you could also give a more granular config to the """advanced""" or """power user""", or whoever wants that. For example, Firefox has the about:config page that let the brave ones deeply customize their browser, but also offer options in the gui that are simple to reason about and every user can enjoy.

I actually don't think all of this "advanced user" things applies to this particular issue, but it might be something to think about. I actually loved how easy it was to configure things, so the plugin as is looks very friendly, and this is great.

Maybe have some kind of link or submenu under options that could be more granularly set Something like this:

image

@pg2511 pg2511 mentioned this issue Nov 22, 2023
Draft
@pg2511
Copy link
Member

pg2511 commented Nov 22, 2023

Hello @lucassperez ,

Have a look at this:
toggle cards shortcut.webm

I hope now it will be meeting your needs now. Feel free to tell us more improvisations you need 🙂. Will be more than happy to improve user experience.

@lucassperez
Copy link
Author

@PG-257811 this looks perfect, to be honest!

@pg2511
Copy link
Member

pg2511 commented Nov 22, 2023

Thanks @lucassperez for your feedback, @ImprovedTube I think now this PR (#1847) can be merged.

ImprovedTube added a commit that referenced this issue Nov 23, 2023
@ImprovedTube
#1845 #1848
f80bd99
ImprovedTube added a commit that referenced this issue Nov 23, 2023
@ImprovedTube
#1845 #1848
3e419ed
@ImprovedTube
Copy link
Member

sorry for all the verbosity. I didnt consider the "endcards"(~4x3 thumbnails), might also appear while the last frame of the video is visible...? - so anyhow:

old shortcut: toggle cards
new shortcut: toggle overlays (cards, endcards & title in fullscreen), until i leave the video

So to hide (or show when hidden by default) for two videos in a row, you'd need to also press both times, so that it cant be forgotten by mistake when toggled by shortcut - Yet i guess this will make the best UX? @lucassperez

( thought of adding title in fullscreen at once with adding that feature, which was also really efficient/motivating? :

check out: 3e419ed

(css only as of those <html>-tag- attributes...)

@lucassperez
Copy link
Author

Sounds like a good user experience, yes.

@ImprovedTube ImprovedTube added Completion / Revision Rethink, complete, improve, tweak our feature or structure. and removed Bug Bug or required update after YouTube changes labels Nov 23, 2023
ImprovedTube added a commit that referenced this issue Jan 12, 2024
@ImprovedTube
#1845 #1848
3542bbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Completion / Revision Rethink, complete, improve, tweak our feature or structure. Exemplary! worth reading & repeating. good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. UI (UX) about our UI (UX) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
Priority A
Status: Done
Milestone
Little or easy
Development

No branches or pull requests
3 participants
@ImprovedTube @pg2511 @lucassperez