Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very translates updated, some keys for some strings fixed and linked with crowdim. #1921

Merged
merged 367 commits into from
Jan 9, 2024
Merged

Conversation

unnamed-orbert
Copy link
Contributor

Original Pull resquest: #1916

Hey, I realized here that the problem we're trying to solve is a very old problem.
I propose the following solutions:

  • Use Crowdin for mass duplication and translation into the most popular languages (Would solve 30% of the problem)
    Unfortunately Crowdin has a duent restriction of 60000 words!

  • Use manual translation by requesting a notice on the website, on the project page and in the extension for languages that are not on Crowdin
    (Manual checking will be complicated)

  • Update localy.py file list manually

I'm sure we don't have the time or patience to be able to replicate text for more than 100 files, I don't have the knowledge at the moment to make a bot.

If possible, I would be happy if you could merge the changes I made and correct the keys by adding them to the _locales/en/messagens.json file

@ImprovedTube ImprovedTube merged commit d9a4e36 into code-charity:master Jan 9, 2024
@ImprovedTube
Copy link
Member

♡♡♡

ImprovedTube added a commit that referenced this pull request Jan 10, 2024
@ImprovedTube
Copy link
Member

ImprovedTube commented Jan 10, 2024

thank you! @unnamed-orbert Sorry(!) didn't want to bloat your workload!😳
Other extensions might fall back to english ( https://developer.chrome.com/docs/extensions/reference/api/i18n and pre-populating files is not required.

Yet our code currently only loads one locale file all at once, so it has to be complete (possibly reduces I/O load?).
(And chrome functions only supports 55 locales).

so starting today our function will consider all (up to) 3 files: 5254632

  • and also consider if a user set a longer ordered list of languages ( chrome://settings/languages )

So we can undo the pre-population.
(Sorry)

60000

we have only 376 massages with 850 words.
(with no more pre-population we can use more languages in crowdim)

  • BTW, we can sum up part of pt_BR pt_PT as a new: pt

  • BTW our list at settings ⋮, ⚙️ uses the same 83 language options as YouTube does 🤔 and some we got arent selectable yet like fa_IR and no_NB 2a57f51

ImprovedTube added a commit that referenced this pull request Jan 10, 2024
@ImprovedTube
Copy link
Member

hi @unnamed-orbert

RE: #1928

  • BTW, we can sum up part of pt_BR pt_PT as a new: pt

sorry, didnt mean to ask to remove pt_BR & pt_PT
just wonder about efficency /summing up part and keeping the 60 000 words limit.

es_419: 1 unique message (yet)
en_US: 9 unique message ~ 2.2%
en_GB: 10 unique messages ~ 2.5%
fa_IR: 32 unique messages ~ 7.9%
nb_NO: 66 unique messages ~ 16.4%
pt_BR & pt_PT: 146 differing messages ~ 36.2%
zh_CN & zh_TW: 165 differing messages ~ 40.9%

...
diff -e _locales/en/* _locales/en_US/* | grep message | wc -l
18
diff -e _locales/en/* _locales/en_GB/* | grep message | wc -l
20
...
diff -e _locales/pt_PT/* _locales/pt_BR/* | grep message | wc -l
294
diff -e _locales/zh_CN/* _locales/zh_TW/* | grep message | wc -l
330

@ImprovedTube
Copy link
Member

firefox addons

ImprovedTube added a commit that referenced this pull request Jan 12, 2024
Very translates updated, some keys for some strings fixed and linked with crowdim.
ImprovedTube added a commit that referenced this pull request Jan 12, 2024
ImprovedTube added a commit that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants