From be7471ee8aadf6a6a6c1af2e3ceb35e48a372759 Mon Sep 17 00:00:00 2001 From: Igor Katsuba Date: Mon, 13 Nov 2023 23:04:01 +0200 Subject: [PATCH] fix(utils,cli): remove all mentions of the `interactive` option (#245) Close #120 --- packages/cli/src/lib/implementation/model.ts | 2 +- packages/utils/src/lib/execute-process.spec.ts | 8 ++++---- packages/utils/src/lib/execute-process.ts | 1 - 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/packages/cli/src/lib/implementation/model.ts b/packages/cli/src/lib/implementation/model.ts index 6ca334195..419d495c8 100644 --- a/packages/cli/src/lib/implementation/model.ts +++ b/packages/cli/src/lib/implementation/model.ts @@ -1,6 +1,6 @@ import { Format, GlobalOptions } from '@code-pushup/models'; -// type GeneralCliOnlyOptions = { progress: boolean }; // @TODO consider interactive and progress as CLI only options +// type GeneralCliOnlyOptions = { progress: boolean }; // @TODO consider progress as CLI only options export type GeneralCliOptions = GlobalOptions; export type CoreConfigCliOptions = { diff --git a/packages/utils/src/lib/execute-process.spec.ts b/packages/utils/src/lib/execute-process.spec.ts index f2e887ecb..d32dd7f8b 100644 --- a/packages/utils/src/lib/execute-process.spec.ts +++ b/packages/utils/src/lib/execute-process.spec.ts @@ -86,15 +86,15 @@ describe('objectToCliArgs', () => { }); it('should handle boolean arguments', () => { - const params = { interactive: true }; + const params = { progress: true }; const result = objectToCliArgs(params); - expect(result).toEqual(['--interactive']); + expect(result).toEqual(['--progress']); }); it('should handle negated boolean arguments', () => { - const params = { interactive: false }; + const params = { progress: false }; const result = objectToCliArgs(params); - expect(result).toEqual(['--no-interactive']); + expect(result).toEqual(['--no-progress']); }); it('should handle array of string arguments', () => { diff --git a/packages/utils/src/lib/execute-process.ts b/packages/utils/src/lib/execute-process.ts index 838e2ed52..80290046a 100644 --- a/packages/utils/src/lib/execute-process.ts +++ b/packages/utils/src/lib/execute-process.ts @@ -182,7 +182,6 @@ export type CliArgsObject> = * const args = objectToProcessArgs({ * _: ['node', 'index.js'], // node index.js * name: 'Juanita', // --name=Juanita - * interactive: false, // --no-interactive * formats: ['json', 'md'] // --format=json --format=md * }); */