Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple usage for values from remote config at "About page" #216

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Add simple usage for values from remote config at "About page" #216

merged 1 commit into from
Oct 7, 2020
+36 −6

Conversation

DeKaN
Copy link
Contributor

@DeKaN DeKaN commented Oct 1, 2020

Add loading values from config fetched at App start
Closes #211

@DeKaN DeKaN requested a review from aniri as a code owner October 1, 2020 22:45
@sonarcloud
Copy link

sonarcloud bot commented Oct 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aniri aniri merged commit 904c80d into code4romania:develop Oct 7, 2020
@aniri aniri mentioned this pull request Oct 7, 2020
Merged
@DeKaN DeKaN deleted the about-fragment-simple-remote-config branch October 7, 2020 20:35
DeKaN added a commit to DeKaN/mon-vot-android-kotlin that referenced this pull request Oct 7, 2020
@DeKaN
Merge code from code4romania#216. Remove WebClient
2785e66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniri aniri aniri approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load about page links from remote configs
2 participants
@DeKaN @aniri