From 4ed055c874276bf49fc49f29370076e6a783e72d Mon Sep 17 00:00:00 2001 From: kobenguyent Date: Fri, 17 Jan 2025 09:49:39 +0100 Subject: [PATCH 1/2] fix: screenshots for sessions --- lib/helper/WebDriver.js | 4 ++-- test/acceptance/session_test.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/helper/WebDriver.js b/lib/helper/WebDriver.js index e55b51cf8..a53d08787 100644 --- a/lib/helper/WebDriver.js +++ b/lib/helper/WebDriver.js @@ -1788,14 +1788,14 @@ class WebDriver extends Helper { if (browser) { this.debug(`Screenshot of ${sessionName} session has been saved to ${outputFile}`) - return browser.saveScreenshot(outputFile) + await browser.saveScreenshot(outputFile) } } } if (!fullPage) { this.debug(`Screenshot has been saved to ${outputFile}`) - return this.browser.saveScreenshot(outputFile) + await this.browser.saveScreenshot(outputFile) } const originalWindowSize = await this.browser.getWindowSize() diff --git a/test/acceptance/session_test.js b/test/acceptance/session_test.js index 98812a331..9b39e4de1 100644 --- a/test/acceptance/session_test.js +++ b/test/acceptance/session_test.js @@ -77,7 +77,7 @@ Scenario('Different cookies for different sessions @Playwright @Puppeteer', asyn I.expectNotEqual(cookies.john, cookies.mary) }) -Scenario('should save screenshot for sessions @Puppeteer @Playwright', async function ({ I }) { +Scenario('should save screenshot for sessions @Puppeteer @Playwright @WebDriver', async function ({ I }) { await I.amOnPage('/form/bug1467') await I.saveScreenshot('original.png') await I.amOnPage('/') From 6ec87b2b05170ed5c09db80cea24660baadb7a34 Mon Sep 17 00:00:00 2001 From: kobenguyent Date: Fri, 17 Jan 2025 10:02:15 +0100 Subject: [PATCH 2/2] fix: screenshots for sessions --- test/acceptance/session_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/acceptance/session_test.js b/test/acceptance/session_test.js index 9b39e4de1..98812a331 100644 --- a/test/acceptance/session_test.js +++ b/test/acceptance/session_test.js @@ -77,7 +77,7 @@ Scenario('Different cookies for different sessions @Playwright @Puppeteer', asyn I.expectNotEqual(cookies.john, cookies.mary) }) -Scenario('should save screenshot for sessions @Puppeteer @Playwright @WebDriver', async function ({ I }) { +Scenario('should save screenshot for sessions @Puppeteer @Playwright', async function ({ I }) { await I.amOnPage('/form/bug1467') await I.saveScreenshot('original.png') await I.amOnPage('/')