Extend YAML configuration to handle "only notify on negative change" #1966
Assignees
Comments
giovanni-guidini
added a commit
to codecov/shared
that referenced
this issue
Jun 21, 2024
We are extending the configuration for required_changes. ticket: codecov/engineering-team#1966 I might have overengineered the different conditions, but being able to combine in both AND and OR operations is somewhat tricky. In the end it's a satisfaction problem in that all the elements in the conditions list need to be satisfied for the comment to occur, and the elements themselves express and OR grouping.
This was referenced Jun 21, 2024
giovanni-guidini
added a commit
to codecov/shared
that referenced
this issue
Jun 26, 2024
We are extending the configuration for required_changes. ticket: codecov/engineering-team#1966 I might have overengineered the different conditions, but being able to combine in both AND and OR operations is somewhat tricky. In the end it's a satisfaction problem in that all the elements in the conditions list need to be satisfied for the comment to occur, and the elements themselves express and OR grouping.
github-merge-queue bot
pushed a commit
to codecov/shared
that referenced
this issue
Jun 27, 2024
* feat: extend configuration for `comment.required_changes` We are extending the configuration for required_changes. ticket: codecov/engineering-team#1966 I might have overengineered the different conditions, but being able to combine in both AND and OR operations is somewhat tricky. In the end it's a satisfaction problem in that all the elements in the conditions list need to be satisfied for the comment to occur, and the elements themselves express and OR grouping. * one more test * chore: use parsing lib Use a proper parsing lib instead of ad-hoc code to parse the required_changes string options. Interface remains unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
New options for Coverage
Extends options of
comment.require_changes. Default remainFalsecoverage_drop- [project coverage] only post comment if coverage drops more than <coverage.status.project.threshold> percent when comparing HEAD to BASEuncovered_patch- [patch coverage] only post comment if the patch has uncovered linesobs.: It should also be possible to combine the new options. For example "coverage_drop AND uncovered_patch", "coverage_drop OR uncovered_patch"
The text was updated successfully, but these errors were encountered: