Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend YAML configuration with bundle changes and threshold #2018

Closed
3 tasks done
Tracked by #1350
giovanni-guidini opened this issue Jun 28, 2024 · 0 comments · Fixed by codecov/shared#271
Closed
3 tasks done
Tracked by #1350

Extend YAML configuration with bundle changes and threshold #2018

giovanni-guidini opened this issue Jun 28, 2024 · 0 comments · Fixed by codecov/shared#271
Assignees
@giovanni-guidini
Labels
enhancement New feature or request

Comments

@giovanni-guidini
Copy link

giovanni-guidini commented Jun 28, 2024 •
edited
Loading

We want to extend the required changes to emit a bundle analysis comment.
The work was partially done in codecov/shared#259 when we extended the coverage comment.

This ticket is focused on the Bundle Analysis that needs some extra steps to be usable.

Steps

  • Add tests for require_bundle_changes
  • Create coercion class for bundle_change_threshold to transform to bytes value
  • Update documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@giovanni-guidini giovanni-guidini

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: bundle analysis comment threshold codecov/shared
1 participant
@giovanni-guidini