From 9a77add1f639d2557e1eb0be1a503ef65077b637 Mon Sep 17 00:00:00 2001
From: nicholas-codecov <nicholas.deschenes@sentry.io>
Date: Fri, 24 Jan 2025 13:40:11 -0400
Subject: [PATCH] fix: PullCoverage a passing null instead of boolean (#3679)

---
 ...llCoverage.test.jsx => PullCoverage.test.tsx} | 16 +++++++++++++---
 .../{PullCoverage.jsx => PullCoverage.tsx}       | 13 ++++++++++---
 .../PullCoverage/{index.js => index.ts}          |  0
 3 files changed, 23 insertions(+), 6 deletions(-)
 rename src/pages/PullRequestPage/PullCoverage/{PullCoverage.test.jsx => PullCoverage.test.tsx} (97%)
 rename src/pages/PullRequestPage/PullCoverage/{PullCoverage.jsx => PullCoverage.tsx} (94%)
 rename src/pages/PullRequestPage/PullCoverage/{index.js => index.ts} (100%)

diff --git a/src/pages/PullRequestPage/PullCoverage/PullCoverage.test.jsx b/src/pages/PullRequestPage/PullCoverage/PullCoverage.test.tsx
similarity index 97%
rename from src/pages/PullRequestPage/PullCoverage/PullCoverage.test.jsx
rename to src/pages/PullRequestPage/PullCoverage/PullCoverage.test.tsx
index c1e4cc700a..1aa0a34910 100644
--- a/src/pages/PullRequestPage/PullCoverage/PullCoverage.test.jsx
+++ b/src/pages/PullRequestPage/PullCoverage/PullCoverage.test.tsx
@@ -44,7 +44,7 @@ vi.mock('./routes/ComponentsTab', () => ({
   default: () => <div>ComponentsTab</div>,
 }))
 
-const mockPullData = (resultType) => {
+const mockPullData = (resultType: string) => {
   if (resultType !== ComparisonReturnType.SUCCESSFUL_COMPARISON) {
     return {
       owner: {
@@ -181,7 +181,9 @@ const queryClientV5 = new QueryClientV5({
 })
 
 const wrapper =
-  (initialEntries = '/gh/codecov/test-repo/pull/1') =>
+  (
+    initialEntries = '/gh/codecov/test-repo/pull/1'
+  ): React.FC<React.PropsWithChildren> =>
   ({ children }) => (
     <QueryClientProviderV5 client={queryClientV5}>
       <QueryClientProvider client={queryClient}>
@@ -213,6 +215,14 @@ afterAll(() => {
   server.close()
 })
 
+interface SetupArgs {
+  resultType?: string
+  isTeamPlan?: boolean
+  bundleAnalysisEnabled?: boolean
+  coverageEnabled?: boolean
+  isGithubRateLimited?: boolean
+}
+
 describe('PullRequestPageContent', () => {
   function setup(
     {
@@ -221,7 +231,7 @@ describe('PullRequestPageContent', () => {
       bundleAnalysisEnabled = false,
       coverageEnabled = false,
       isGithubRateLimited = false,
-    } = {
+    }: SetupArgs = {
       resultType: ComparisonReturnType.SUCCESSFUL_COMPARISON,
       isTeamPlan: false,
       bundleAnalysisEnabled: false,
diff --git a/src/pages/PullRequestPage/PullCoverage/PullCoverage.jsx b/src/pages/PullRequestPage/PullCoverage/PullCoverage.tsx
similarity index 94%
rename from src/pages/PullRequestPage/PullCoverage/PullCoverage.jsx
rename to src/pages/PullRequestPage/PullCoverage/PullCoverage.tsx
index 57a2f1831d..467726a530 100644
--- a/src/pages/PullRequestPage/PullCoverage/PullCoverage.jsx
+++ b/src/pages/PullRequestPage/PullCoverage/PullCoverage.tsx
@@ -34,8 +34,15 @@ const Loader = () => (
   </div>
 )
 
+interface URLParams {
+  owner: string
+  repo: string
+  pullId: string
+  provider: string
+}
+
 function PullCoverageContent() {
-  const { owner, repo, pullId, provider } = useParams()
+  const { owner, repo, pullId, provider } = useParams<URLParams>()
   const { data: overview } = useRepoOverview({ provider, owner, repo })
   const { data: isTeamPlan } = useIsTeamPlan({ provider, owner })
 
@@ -123,7 +130,7 @@ function PullCoverageContent() {
 }
 
 function PullCoverage() {
-  const { owner, repo, pullId, provider } = useParams()
+  const { owner, repo, pullId, provider } = useParams<URLParams>()
   const { data: overview } = useRepoOverview({ provider, owner, repo })
   const { data: isTeamPlan } = useIsTeamPlan({ provider, owner })
   const { data: rateLimit } = useRepoRateLimitStatus({ provider, owner, repo })
@@ -134,7 +141,7 @@ function PullCoverage() {
       owner,
       repo,
       pullId,
-      isTeamPlan: isTeamPlan && overview?.private,
+      isTeamPlan: (isTeamPlan && overview?.private) ?? false,
     })
   )
 
diff --git a/src/pages/PullRequestPage/PullCoverage/index.js b/src/pages/PullRequestPage/PullCoverage/index.ts
similarity index 100%
rename from src/pages/PullRequestPage/PullCoverage/index.js
rename to src/pages/PullRequestPage/PullCoverage/index.ts