feat: bundle analysis comment threshold #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes improve documentation (and add unit tests) to `comment.require_bundle_changes` and adds a new config key `bundle_change_threshold`. The new key is a threshold size for the bundle in bytes. The input value is preferably a string that accepts certain size extensions (kb, mb, gb, ...) and is coerced into a size in bytes (as an integer)
giovanni-guidini
force-pushed
the
gio/coerce-bundle-threshold
branch
from
4ef3dfb
to
68ecee0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #271 +/- ##
==========================================
- Coverage 90.17% 89.44% -0.73%
==========================================
Files 351 324 -27
Lines 11079 10184 -895
Branches 1969 1841 -128
==========================================
- Hits 9990 9109 -881
+ Misses 1015 1005 -10
+ Partials 74 70 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
giovanni-guidini
added a commit
to codecov/worker
that referenced
this pull request
Jul 1, 2024
Updates the comment requirements for bundle_analysis. Respects the `comment.bundle_change_threshold` defined in the YAML and only notifies if changes are bigger than the threshold. (threshold is expected to be an int. So technically [this PR](codecov/shared#271) is a dependency of the present changes, because it does the coercion into an integer, as expected) Also adds the `"bundle_increase"` as a possible requirements. In this case on top of the threshold the change also needs to cause the bundle to _increase_ in size for a comment to be sent. closes: codecov/engineering-team#2021
| @@ -147,6 +147,38 @@ def validate_str(self, data: str) -> CoverageCommentRequiredChangesANDGroup: | |||
| raise Invalid("Failed to parse required_changes") | |||
|
|
|||
|
|
|||
| class ByteSizeSchemaField(object): | |||
There was a problem hiding this comment.
Nice class! Very well organized, documented, easy to read
adrian-codecov
approved these changes
Jul 3, 2024
giovanni-guidini
added a commit
to codecov/worker
that referenced
this pull request
Jul 4, 2024
Updates the comment requirements for bundle_analysis. Respects the `comment.bundle_change_threshold` defined in the YAML and only notifies if changes are bigger than the threshold. (threshold is expected to be an int. So technically [this PR](codecov/shared#271) is a dependency of the present changes, because it does the coercion into an integer, as expected) Also adds the `"bundle_increase"` as a possible requirements. In this case on top of the threshold the change also needs to cause the bundle to _increase_ in size for a comment to be sent. closes: codecov/engineering-team#2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes improve documentation (and add unit tests) to
comment.require_bundle_changesand adds a new config key
bundle_change_threshold.The new key is a threshold size for the bundle in bytes. The input value
is preferably a string that accepts certain size extensions (kb, mb, gb, ...) and is
coerced into a size in bytes (as an integer)
closes: codecov/engineering-team#2018
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.