1164 adjust archive get fn error call #453
Conversation
…chive-get-fn-error-call
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #453 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 399 399
Lines 33611 33612 +1
=======================================
+ Hits 32719 32720 +1
Misses 892 892
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 399 399
Lines 33611 33612 +1
=======================================
+ Hits 32719 32720 +1
Misses 892 892
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #453 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 399 399
Lines 33611 33612 +1
=======================================
+ Hits 32719 32720 +1
Misses 892 892
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 430 430
Lines 34301 34302 +1
=======================================
+ Hits 33400 33401 +1
Misses 901 901
Flags with carried forward coverage won't be shown. Click here to find out more.
|
We're seeing timeseries errors pop in sentry that look like this: https://codecov.sentry.io/issues/4354360482/?project=5215654&project=4506250072489984&project=4505534345838592&project=4506739665207296&project=4505562661847040&project=4505562669645824&project=4505562667089920&project=4505743290269696&project=4503926675144704&project=1260170&project=4504171287871488&project=4505225779675136&project=4506634728833024&project=4506317072891904&project=4505131799150592&project=4165036&project=5514400&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D+save_commit_measurements&referrer=issue-stream&statsPeriod=30d&stream_index=1&utc=true. I looked up in our logs that this error is shortly followed by "Archive enabled field found in storage after delay"., so we're erroring and quickly recovering from it, yet spamming our sentry logs with this. More details and specifics here codecov/engineering-team#1164
This PR is to only log an error after the retry timeout is over, and still warn when we retry.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.