Skip to content

Commit d9e66d6

Browse files
authored
Python3 steps pr devel (#22)
* 1.x dev (#19) * Contribute docs (#12) * Staging 1.1.10 release to test CI. * Starting some contributor docs. * Minor change to tag deletion. * Making separate CI file for PR tests. (#14) * Updating domain_name to _domain_name. * Adding _domain_name var to blank template too. * Updating _domain_name var for controller. * env_type also becomes _env_type. * Adding _env_type to blank template. * Adding _env_type to drupal8 template. * Adding _env_type to drupal8 deploy template. * Adding _env_type to blank deploy template. * Try adding _env_type directly to PHP CLI role vars. * Explicitly adding fpm var required. * Fixing Dockerfile to install Ansible from pip. * Installing boto3 from pip. * Rogue 'i'. * Rogue 'i'. * Updating ansible path. * Wrong path. * Set Python3 as default on controller. * Adding Ansible galaxy var. * Setting the base container to use python3 as default. * Adding pip3 to base container. * Moving to _domain_name to be consistent with other projects.
1 parent 87a1d7a commit d9e66d6

File tree

5 files changed

+16
-17
lines changed

5 files changed

+16
-17
lines changed

docker-images/base/Dockerfile

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,10 @@ RUN \
3636
openssh-server \
3737
postfix \
3838
procmail \
39-
python-apt \
40-
python-dev \
41-
python-pycurl \
39+
python3-apt \
40+
python3-dev \
41+
python3-pycurl \
42+
python3-pip \
4243
rsyslog \
4344
sudo \
4445
systemd \
@@ -47,6 +48,7 @@ RUN \
4748
vim \
4849
wget && \
4950
apt-get clean && \
51+
update-alternatives --install /usr/bin/python python /usr/bin/python3 1 && \
5052
rm -rf \
5153
/var/lib/apt/lists/* \
5254
/var/log/* \

docker-images/controller/Dockerfile

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,13 @@ FROM codeenigma/ce-dev-1.x:latest
33
RUN \
44
set -x && \
55
export DEBIAN_FRONTEND=noninteractive && \
6-
echo 'deb http://ppa.launchpad.net/ansible/ansible/ubuntu trusty main' > /etc/apt/sources.list.d/ansible.list && \
7-
apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 93C4A3FD7BB9C367 && \
86
apt-get update && \
97
apt-get dist-upgrade -y -o Dpkg::Options::="--force-confnew" && \
108
apt-get install -y -o Dpkg::Options::="--force-confnew" \
11-
ansible \
12-
python-boto3 \
139
git && \
1410
apt-get clean && \
11+
pip3 install ansible boto3 && \
12+
update-alternatives --install /usr/bin/python python /usr/bin/python3 1 && \
1513
rm -rf \
1614
/var/lib/apt/lists/* \
1715
/var/log/* \
@@ -25,13 +23,11 @@ COPY ./provision.yml /home/ce-dev/ce-provision/provision.yml
2523
RUN \
2624
set -x && \
2725
export DEBIAN_FRONTEND=noninteractive && \
28-
echo 'deb http://ppa.launchpad.net/ansible/ansible/ubuntu trusty main' > /etc/apt/sources.list.d/ansible.list && \
29-
apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 93C4A3FD7BB9C367 && \
3026
apt-get update && \
31-
su - ce-dev -c "/usr/bin/ansible-playbook /home/ce-dev/ce-provision/provision.yml" && \
27+
su - ce-dev -c "/usr/local/bin/ansible-playbook /home/ce-dev/ce-provision/provision.yml" && \
3228
rm /home/ce-dev/ce-provision/provision.yml && \
3329
apt-get clean && \
3430
rm -rf \
3531
/var/lib/apt/lists/* \
3632
/var/log/* \
37-
/tmp/*
33+
/tmp/*

docker-images/controller/provision.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
username: ce-dev
2626
local_dir: /home/ce-dev/ce-provision
2727
groups: []
28+
galaxy_custom_requirements_file: ""
2829
roles:
2930
- ce_provision
3031
- ce_deploy

templates/drupal8/ce-dev/ansible/deploy.yml.j2

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
- build_type: local
99
- _env_type: dev
1010
{% raw %}
11-
- domain_name: www.{{ project_name }}.local
11+
- _domain_name: www.{{ project_name }}.local
1212
# Path to your project root. This must match the "volume" set in the docker-compose template.
1313
- deploy_path: /home/ce-dev/deploy/live.local
1414
# This actually does not take any backup, but is needed to populate settings.php.
@@ -27,7 +27,7 @@
2727
sanitize_command: "sql-sanitize"
2828
# Remove after initial pass, to avoid reinstalling Drupal.
2929
force_install: yes
30-
base_url: "https://{{ domain_name }}"
30+
base_url: "https://{{ _domain_name }}"
3131
# Composer command to run.
3232
- composer:
3333
command: install

templates/drupal8/ce-dev/ansible/provision.yml.j2

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,16 @@
1212
- env_type: dev
1313
- nginx:
1414
domains:
15-
- server_name: "{{ domain_name }}"
15+
- server_name: "{{ _domain_name }}"
1616
access_log: "/var/log/nginx-access.log"
1717
error_log: "/var/log/nginx-error.log"
1818
error_log_level: "notice"
1919
webroot: "/home/ce-dev/deploy/live.local/web"
2020
project_type: "drupal8"
2121
ssl:
22-
domain: "{{ domain_name }}"
23-
cert: "{{ _ce_dev_mkcert_base}}/{{ domain_name }}.pem"
24-
key: "{{ _ce_dev_mkcert_base}}/{{ domain_name }}-key.pem"
22+
domain: "{{ _domain_name }}"
23+
cert: "{{ _ce_dev_mkcert_base}}/{{ _domain_name }}.pem"
24+
key: "{{ _ce_dev_mkcert_base}}/{{ _domain_name }}-key.pem"
2525
handling: "unmanaged"
2626
ratelimitingcrawlers: no
2727
is_default: yes

0 commit comments

Comments
 (0)