From 8de879350bad8b7bcb43424c0c463809a0331543 Mon Sep 17 00:00:00 2001 From: Zach J Date: Tue, 6 Apr 2021 19:31:50 -0400 Subject: [PATCH] Issue #308 Android bug fixes (#311) * Replace TouchableOpacity with View This TouchableOpacity does not appear to be doing anything, and we think it may be causing accessibility warnings in the Android pre-launch tests, since it does not have accessibility attributes. It seems safe to make it a View instead. * Android bug fixes * Attempt to resolve camera permissions error by adding android permission "READ_EXTERNAL_STORAGE" * Resolve error when deleting a plog which has a photo attached by adding delete permission to storage rules Co-authored-by: B. Sanders Co-authored-by: Ben Lewis Co-authored-by: VA Kenyon Co-authored-by: B. Sanders Co-authored-by: Ben Lewis Co-authored-by: VA Kenyon --- app.config.js | 2 +- firebase/project/storage.rules | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app.config.js b/app.config.js index aa0458b..af3d231 100644 --- a/app.config.js +++ b/app.config.js @@ -97,7 +97,7 @@ export default ({config}) => { "package": androidBundleIdentifier, "googleServicesFile": googleServicesJson, // "softwareKeyboardLayoutMode": "pan", - "permissions": ["CAMERA", "CAMERA_ROLL", "ACCESS_FINE_LOCATION"], + "permissions": ["CAMERA", "CAMERA_ROLL", "ACCESS_FINE_LOCATION", "READ_EXTERNAL_STORAGE"], "versionCode": 7, "intentFilters": [ { diff --git a/firebase/project/storage.rules b/firebase/project/storage.rules index 98240d1..79ef41c 100644 --- a/firebase/project/storage.rules +++ b/firebase/project/storage.rules @@ -32,6 +32,7 @@ service firebase.storage { allow write: if isUploadAllowed() && n.matches("[0-9]\\.jpg"); allow read: if isPublic() || isOwner(); + allow delete: if isOwner(); } match /plog/profile.jpg {