Skip to content

Enforce code style using spotless #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Enforce code style using spotless #154

wants to merge 3 commits into from
+65 −70

Conversation

gnodet
Copy link
Member

@gnodet gnodet commented Apr 21, 2023

No description provided.

@gnodet gnodet requested a review from slawekjaranowski April 21, 2023 09:07
olamy
olamy reviewed Apr 21, 2023
View reviewed changes
@slachiewicz
Copy link
Member

fyi codehaus-plexus/plexus-classworlds#74

slawekjaranowski
slawekjaranowski reviewed Apr 21, 2023
View reviewed changes
pom.xml
<executions>
<execution>
<goals>
<goal>apply</goal>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check?

pom.xml
@@ -343,29 +342,6 @@ limitations under the License.
<artifactId>maven-assembly-plugin</artifactId>
<version>3.5.0</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be also removed from reporting profile.

@slawekjaranowski
Copy link
Member

I hope it will be usable, @gnodet - do you work on it

@slachiewicz
Copy link
Member

be carefull with license header file removal #166 as we depend on this file in previous parent-pom versions

@slawekjaranowski
Copy link
Member

be carefull with license header file removal #166 as we depend on this file in previous parent-pom versions

so must be preserved until all projects switch to new parent version

@slachiewicz
Copy link
Member

be carefull with license header file removal #166 as we depend on this file in previous parent-pom versions

so must be preserved until all projects switch to new parent version

Yes, thats why I propose two steps aproach - now just set it to stable location, projects can update with dependabot or manyally with cleanup
Then when we finish decision how to deal with multiple license headers - we can implement spotless

@gnodet gnodet closed this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy

@slawekjaranowski slawekjaranowski

@slachiewicz slachiewicz

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gnodet @slachiewicz @slawekjaranowski @olamy