From ac1c4a5f189aa432ef396d983c3899f79d61479c Mon Sep 17 00:00:00 2001 From: ping-yee <611077101@mail.nknu.edu.tw> Date: Mon, 5 Sep 2022 17:13:22 +0800 Subject: [PATCH 1/3] test: fix failure of testStreamFilter function. --- tests/system/Test/TestCaseTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/system/Test/TestCaseTest.php b/tests/system/Test/TestCaseTest.php index 9657c65741d3..de9a27b174f3 100644 --- a/tests/system/Test/TestCaseTest.php +++ b/tests/system/Test/TestCaseTest.php @@ -56,7 +56,7 @@ public function testStreamFilter() CITestStreamFilter::$buffer = ''; $this->stream_filter = stream_filter_append(STDOUT, 'CITestStreamFilter'); CLI::write('first.'); - $expected = "first.\n"; + $expected = "\nfirst.\n"; $this->assertSame($expected, CITestStreamFilter::$buffer); stream_filter_remove($this->stream_filter); } From 13a3248859f87bf4b188b1cbdf0fbc5293d40e80 Mon Sep 17 00:00:00 2001 From: ping-yee <611077101@mail.nknu.edu.tw> Date: Fri, 9 Sep 2022 19:26:18 +0800 Subject: [PATCH 2/3] add: setup function --- tests/system/Test/TestCaseTest.php | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/system/Test/TestCaseTest.php b/tests/system/Test/TestCaseTest.php index de9a27b174f3..6662f8e7f814 100644 --- a/tests/system/Test/TestCaseTest.php +++ b/tests/system/Test/TestCaseTest.php @@ -27,6 +27,14 @@ final class TestCaseTest extends CIUnitTestCase */ private $stream_filter; + protected function setUp(): void + { + parent::setUp(); + + // Reset CLI::$lastWrite + CLI::print(); + } + public function testGetPrivatePropertyWithObject() { $obj = new __TestForReflectionHelper(); From 8030ae050c699af0a83c9b02e5f9f44c12d26601 Mon Sep 17 00:00:00 2001 From: ping-yee <611077101@mail.nknu.edu.tw> Date: Sat, 10 Sep 2022 02:21:17 +0800 Subject: [PATCH 3/3] cs-fix --- tests/system/Test/TestCaseTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/system/Test/TestCaseTest.php b/tests/system/Test/TestCaseTest.php index 6662f8e7f814..f8253964a528 100644 --- a/tests/system/Test/TestCaseTest.php +++ b/tests/system/Test/TestCaseTest.php @@ -30,7 +30,7 @@ final class TestCaseTest extends CIUnitTestCase protected function setUp(): void { parent::setUp(); - + // Reset CLI::$lastWrite CLI::print(); }