diff --git a/CHANGELOG.md b/CHANGELOG.md index 7777126c..ab390d56 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,9 @@ Version 0.34.3 ------------- +**Bugfix**: +- Fix action `xcode-project detect-bundle-id` for cases when `xcodebuild -showBuildSettings` output does not have `PRODUCT_BUNDLE_IDENTIFIER` entry for some build settings. [PR #280](https://github.com/codemagic-ci-cd/cli-tools/pull/280) + **Improvements**: - Action `xcode-project use-profiles` fails in case active Ruby installation does not have `xcodeproj` gem available. Should that happen, show appropriate and actionable error message. [PR #277](https://github.com/codemagic-ci-cd/cli-tools/pull/277) diff --git a/src/codemagic/models/bundle_id_detector.py b/src/codemagic/models/bundle_id_detector.py index aaaa35d5..1492eb71 100644 --- a/src/codemagic/models/bundle_id_detector.py +++ b/src/codemagic/models/bundle_id_detector.py @@ -80,6 +80,7 @@ def _detect_with_xcodebuild(self) -> Iterator[str]: return ( build_setting['buildSettings']['PRODUCT_BUNDLE_IDENTIFIER'] for build_setting in json.loads(stdout) + if build_setting['buildSettings'].get('PRODUCT_BUNDLE_IDENTIFIER') ) def _get_project_configs(self, pbx_project: PbxProject, target: Dict[str, Any]):