From b167dec6ff4abdc03276f28faef5250eca37cb79 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Priit=20L=C3=A4tt?= Date: Tue, 25 Oct 2022 13:58:24 +0300 Subject: [PATCH 1/3] Fix KeyError on bundle identifier detection from project --- src/codemagic/models/bundle_id_detector.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/codemagic/models/bundle_id_detector.py b/src/codemagic/models/bundle_id_detector.py index aaaa35d5..1492eb71 100644 --- a/src/codemagic/models/bundle_id_detector.py +++ b/src/codemagic/models/bundle_id_detector.py @@ -80,6 +80,7 @@ def _detect_with_xcodebuild(self) -> Iterator[str]: return ( build_setting['buildSettings']['PRODUCT_BUNDLE_IDENTIFIER'] for build_setting in json.loads(stdout) + if build_setting['buildSettings'].get('PRODUCT_BUNDLE_IDENTIFIER') ) def _get_project_configs(self, pbx_project: PbxProject, target: Dict[str, Any]): From a64ad3204358cbb0e006432c9f41c4cf822643cc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Priit=20L=C3=A4tt?= Date: Tue, 25 Oct 2022 14:16:23 +0300 Subject: [PATCH 2/3] Update changelog and version --- CHANGELOG.md | 6 ++++++ pyproject.toml | 2 +- src/codemagic/__version__.py | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cc6743c5..159ffd83 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ +Version 0.34.3 +------------- + +**Bugfix**: +- Fix action `xcode-project detect-bundle-id` for cases when `xcodebuild -showBuildSettings` output does not have `PRODUCT_BUNDLE_IDENTIFIER` entry for some build settings. + Version 0.34.2 ------------- diff --git a/pyproject.toml b/pyproject.toml index 5ca1f97a..51c81391 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [tool.poetry] name = "codemagic-cli-tools" -version = "0.34.2" +version = "0.34.3" description = "CLI tools used in Codemagic builds" readme = "README.md" authors = [ diff --git a/src/codemagic/__version__.py b/src/codemagic/__version__.py index fa440930..7b894af5 100644 --- a/src/codemagic/__version__.py +++ b/src/codemagic/__version__.py @@ -1,5 +1,5 @@ __title__ = 'codemagic-cli-tools' __description__ = 'CLI tools used in Codemagic builds' -__version__ = '0.34.2.dev' +__version__ = '0.34.3.dev' __url__ = 'https://github.com/codemagic-ci-cd/cli-tools' __licence__ = 'GNU General Public License v3.0' From fb77ded1794f51673a2f90b67429ee5b3c9f8b0b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Priit=20L=C3=A4tt?= Date: Tue, 25 Oct 2022 14:25:53 +0300 Subject: [PATCH 3/3] Add PR reference to changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 159ffd83..4214e5d6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ Version 0.34.3 ------------- **Bugfix**: -- Fix action `xcode-project detect-bundle-id` for cases when `xcodebuild -showBuildSettings` output does not have `PRODUCT_BUNDLE_IDENTIFIER` entry for some build settings. +- Fix action `xcode-project detect-bundle-id` for cases when `xcodebuild -showBuildSettings` output does not have `PRODUCT_BUNDLE_IDENTIFIER` entry for some build settings. [PR #280](https://github.com/codemagic-ci-cd/cli-tools/pull/280) Version 0.34.2 -------------