🤖 Add OpenAI web_search integration tests #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Test basic web_search tool execution - Test multiple web_search calls in sequence - Test reasoning + web_search combination (regression test for item ID bug) - All tests use gpt-5-codex which supports web_search - Tests verify no errors occur during multi-step execution _Generated with `cmux`_
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
- Reduce to single focused test with constrained prompt - Explicit instruction to use web_search + simple factual query - Increase timeout to 90s for reasoning model processing - Key test: verifies no reasoning itemId errors occur
Use gold price + Collatz computation prompt that: - Always triggers web_search (pricing data needs search) - Requires reasoning for mathematical computation - Sets thinkingLevel: 'high' to ensure reasoning is used - This combination reliably exposes the itemId bug on main Test now validates both reasoning and web_search occurred, making it a true regression test for the itemId bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive integration tests for OpenAI's web_search tool to prevent regressions of the reasoning item ID bug.
Tests Added
Three concurrent integration tests in
tests/ipcMain/openai-web-search.test.ts:Key Features
gpt-5-codexwhich supports web_search toolTesting
These are integration tests that require
OPENAI_API_KEY:Tests run concurrently with appropriate timeouts (45-75 seconds) for real API calls.
Related
openai-fixbranchGenerated with
cmux