Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make check-distutils #2599

Closed
DimitriPapadopoulos opened this issue Nov 17, 2022 · 1 comment
Closed

make check-distutils #2599

DimitriPapadopoulos opened this issue Nov 17, 2022 · 1 comment

Comments

@DimitriPapadopoulos
Copy link
Collaborator

Target check-distutils in the Makefile had not been changed during the pyproject.toml migration (#2523):

codespell/Makefile

Lines 50 to 51 in 1302d79

check-distutils:
python setup.py check --restructuredtext --strict

It is broken:

$ make check-distutils 
python setup.py check --restructuredtext --strict
running check
warning: check: missing required meta-data: name, version, url

warning: check: missing meta-data: either (author and author_email) or (maintainer and maintainer_email) must be supplied

error: Please correct your package.
Makefile:51: recipe for target 'check-distutils' failed
make: *** [check-distutils] Error 1
$ 

We probably want to move away from setup.py check anyway. The alternative appears to be twine check, at least according to Why you shouldn't invoke setup.py directly.

@jdufresne
Copy link
Contributor

The move to twine check was done in ba4e71d. I believe this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants