Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Ignore deliberate "adn" typo in README.rst #1976

Closed
wants to merge 2 commits into from

Conversation

bl-ue
Copy link
Contributor

@bl-ue bl-ue commented Jun 14, 2021

Followup to #1535

@bl-ue bl-ue requested a review from peternewman June 14, 2021 19:49
@bl-ue
Copy link
Contributor Author

bl-ue commented Jun 14, 2021

@peternewman what about https://github.com/codespell-project/codespell/blob/skip-adn-readme-followup1535/.github/workflows/codespell.yml? Should I create a whole new GHA step for just the README? 🤔

@peternewman
Copy link
Collaborator

@peternewman what about https://github.com/codespell-project/codespell/blob/skip-adn-readme-followup1535/.github/workflows/codespell.yml? Should I create a whole new GHA step for just the README? thinking

I don't think you need to particularly, and it might confuse people somewhat if they go to use our action.

Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to ignore .github/workflows/codespell-private.yml in .github/workflows/codespell.yml now. Or better yet explicitly differentiate between .git/* and .github/

.github/workflows/codespell-private.yml Outdated Show resolved Hide resolved
Co-authored-by: Peter Newman <peternewman@users.noreply.github.com>
@bl-ue bl-ue closed this Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants