Add corrections from secdev/scapy#3302 #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @gijs-pennings , The code dictionary is for corrections which will break code, because Jupyther is wrong in any context, it can just go in the normal dictionary. In comparison, we could/should probably add: To the code dictionary, so people who aren't writing about that software tool don't accidentally make a typo for the planet (although probably unlikely). Would you mind opening a new PR to move Jupyther and possibly add the other one too? |
peternewman
added a commit
that referenced
this pull request
Feb 5, 2022
|
I've fixed this all up in #2269 @gijs-pennings |
|
👍 Thanks, I overlooked your comment |
|
Cool, no worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5 typos from secdev/scapy#3302.
I wasn't sure where
"Jupyther"belongs; I added it todictionary_code.txt.