-
Notifications
You must be signed in to change notification settings - Fork 141
Groovyserv POC for develop branch #415
Conversation
jhoffner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pibi looks like there are some ESLint issues that need to be cleaned up.
test/runners/java_spec.js
Outdated
| public static void main(String[] args){ | ||
| System.out.println("42"); | ||
| } | ||
| }`].join('\n') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing, but this can drop the [ and ].join('\n') if we're using template strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks!
| # the travis build process will test it. The process cant test all languages | ||
| # without timing out so this is required to get passed that issue. | ||
| RECENT_CONTAINERS=node | ||
| RECENT_CONTAINERS=java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis build matrix is used now to test all images, so
- TEST_IMG=javaneeds to be added in .travis.yml.
|
@jhoffner Ok, will update it |
|
@pibi looks like Travis is still failing. We will need to get that passing before I can test. I'm also leaving tomorrow on vacation for 2 weeks so no rush. |
|
@jhoffner is this supposed to co-exist with Disable - RUN mocha -t 10000 test/runners/{java,clojure,groovy,scala,kotlin}_spec.js
+ RUN mocha -t 10000 test/runners/{clojure,groovy,scala,kotlin}_spec.js |
|
Thanks @kazk. Yes we can remove java from the jvm docker. |
|
Thanks @kazk , will remove it. To be honest I didn't pay much attention to that because there were 2 different images failing, the JVM (I tought it was using the Makefile, not Travis) and Julia. So, removing java from the jvm-runner will not solve the Travis issue, which will still fail due to the Julia issue |
|
@jhoffner Should I have to disable the Julia job too? |
No description provided.