Skip to content
This repository was archived by the owner on Oct 14, 2020. It is now read-only.

Conversation

@pibi
Copy link
Contributor

@pibi pibi commented May 4, 2017

No description provided.

@pibi pibi changed the title Groovyserv Groovyserv POC for develop May 4, 2017
@pibi pibi changed the title Groovyserv POC for develop Groovyserv POC for develop branch May 4, 2017
Copy link
Member

@jhoffner jhoffner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pibi looks like there are some ESLint issues that need to be cleaned up.

public static void main(String[] args){
System.out.println("42");
}
}`].join('\n')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing, but this can drop the [ and ].join('\n') if we're using template strings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

# the travis build process will test it. The process cant test all languages
# without timing out so this is required to get passed that issue.
RECENT_CONTAINERS=node
RECENT_CONTAINERS=java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis build matrix is used now to test all images, so

- TEST_IMG=java

needs to be added in .travis.yml.

@pibi
Copy link
Contributor Author

pibi commented May 8, 2017

@jhoffner Ok, will update it

@jhoffner
Copy link
Member

@pibi looks like Travis is still failing. We will need to get that passing before I can test. I'm also leaving tomorrow on vacation for 2 weeks so no rush.

@kazk
Copy link
Member

kazk commented May 11, 2017

@jhoffner is this supposed to co-exist with jvm-runner? I think jvm-runner is failing because it's using the modified lib/runners/java.js.

Disable java_spec.js in docker/jvm.docker?

- RUN mocha -t 10000 test/runners/{java,clojure,groovy,scala,kotlin}_spec.js
+ RUN mocha -t 10000 test/runners/{clojure,groovy,scala,kotlin}_spec.js

@jhoffner
Copy link
Member

Thanks @kazk. Yes we can remove java from the jvm docker.

@pibi
Copy link
Contributor Author

pibi commented May 12, 2017

Thanks @kazk , will remove it. To be honest I didn't pay much attention to that because there were 2 different images failing, the JVM (I tought it was using the Makefile, not Travis) and Julia. So, removing java from the jvm-runner will not solve the Travis issue, which will still fail due to the Julia issue

@pibi
Copy link
Contributor Author

pibi commented May 12, 2017

@jhoffner Should I have to disable the Julia job too?

@jhoffner jhoffner merged commit 19a0dba into codewars:develop Jun 5, 2017
@jhoffner jhoffner mentioned this pull request Jun 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants