Ethereum JS #516
Ethereum JS #516
Conversation
- added eventide to ruby
…ons (2.3.3 and 2.4.1)
- JS compiled example contracts - added web3 and related packages for working with ethereum APIs
docker/node.docker
Outdated
| RUN mocha -t 10000 test/runners/typescript_spec.js | ||
| #RUN mocha -t 10000 --recursive test/runners/javascript/ | ||
| #RUN mocha -t 10000 test/runners/coffeescript_spec.js | ||
| #RUN mocha -t 10000 test/runners/typescript_spec.js |
There was a problem hiding this comment.
Whoops, I meant to add those back in. I knew I was going to forget that.
|
|
||
| const runner = require('../../../runner'); | ||
|
|
||
| describe('ethereum', function() { |
There was a problem hiding this comment.
I'm glad I had split javascript_spec.js. Tests are much easier to find and write :)
There was a problem hiding this comment.
Yeah great idea! One thing I did notice is that the new files no longer have _spec as a suffix, and the naming scheme switched to kebob case. Was that on purpose?
There was a problem hiding this comment.
_spec seems redundant to me because these are under test/, but if you want them back I don't mind. kebab case file names are more common in JS projects and matches rest of the codebase.
There was a problem hiding this comment.
Ah, I can't keep them straight. I could have swore this repo was underscore cased, but apparently its just the specs.
The useful thing about _specs is that when using file find its nice to see that a file is a spec (in case there are other files named the same), but also because there may be helper files within the directory that are not actually specs. Not a big deal though.
Dan-Nolan
left a comment
Dan-Nolan
left a comment
There was a problem hiding this comment.
Cool! Looks like a good way to do some more general understanding-the-blockchain challenges. Custom implementations of miners and the merkle-patricia-tree would be interesting as well.
Sure I'll look into adding some enzyme flavored tests. It was a considered library when I first wrote the react challenges, but I stayed away anything non-standard at the time. Jest is another one that might also be requested by teams testing React, but that would replace mocha.
|
What the hell, Travis stopped caring about this PR 😟 |
|
@Dan-Nolan does Enzyme really give users anything they didn't have already? I'm now debating if we should actually accommodate their request. |
|
Apparently angularjs.org is not responding :( |
|
Looks like they got it back up again (that was annoying this morning—no docs!) |
|
I restarted the build. |
…into 8-17/ethereum
- improved contract generation
4 participants
This adds a number of libraries to the node.docker image to work with Ethereum. This is different than the
solidity.dockerfile, which is optimized for working specifically with testing large custom contracts. For this case, we are working with either inline compiled or example contracts and more focused on using the Ethereum API's.Reservations
These API's seem to have stabilized, but I'm concerned that they may still be in flux still and we will have version issues if too much content is built on top of these. I found a number of outdated examples online. With that said, web3 is now at v1.0 (beta) and is the main way of interacting with the API.
Riders