This repository was archived by the owner on Oct 14, 2020. It is now read-only.
Gradle Optimization Improvements #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jhoffner
commented
Sep 1, 2017
jhoffner
commented
- when-prewarmed utility added to ensure we wait until the starting daemon is ready
- cleaned up test cases
- improved test case prewarm integration
- increased jvm memory
- when-prewarmed utility added to ensure we wait until the starting daemon is ready - cleaned up test cases - improved test case prewarm integration - increased jvm memory
Member
|
I don't know why the exit code is 0. Maybe caught by mocha and mocha's exit code is the number of failed tests, so error before failure is 0. |
Member
|
Groovy/Scala performance is about the same on Travis environment :( And I think other tests are terminated early too, it's missing Before Probably related to new |
- added gradle.properties back in - when-prewarmed eslint fix
kazk
reviewed
Sep 2, 2017
lib/utils/when-prewarmed.js
Outdated
| // sets up mocha, also ensures that done never gets called with an argument | ||
| module.exports.setupMocha = function() { | ||
| before(done => ensure(_ => done())); | ||
| after(done => clean(_ => done())); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.