Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted Domains are Duplicated #12

Closed
Tw1sm opened this issue Oct 24, 2024 · 0 comments · Fixed by #14
Closed

Trusted Domains are Duplicated #12

Tw1sm opened this issue Oct 24, 2024 · 0 comments · Fixed by #14
Labels
bug Something isn't working

Comments

@Tw1sm
Copy link
Collaborator

Tw1sm commented Oct 24, 2024

If the same domain is trusted by 2 different domains, the current parsing will treat that trusted domain as 2 different domains, instead of 1 domain that is trusted by multiple others.

For example, if north.sevenkingdoms.local and essos.local BOTH trust sevenkingdoms.local, when we check the trust mesh we will unexpectedly see duplicate nodes for sevenkingdoms.local where the other 2 domains trust "different" nodes.

image

I think the trusted domains need to be set with the same temporary SID instead of unique temp SIDs to resolve this.

@Tw1sm Tw1sm added the bug Something isn't working label Oct 24, 2024
Tw1sm added a commit that referenced this issue Oct 25, 2024
@Tw1sm Tw1sm closed this as completed in #14 Oct 25, 2024
@Tw1sm Tw1sm closed this as completed in bf0eec9 Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant