Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log placeholder for response header values #135

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

ozangoktan
Copy link
Contributor

Adding a log format placeholder for response header values.

@ozangoktan ozangoktan requested a review from a team as a code owner November 7, 2023 07:42
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #135 (a15c09d) into master (80c7bcd) will increase coverage by 0.77%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   76.80%   77.58%   +0.77%     
==========================================
  Files           9        9              
  Lines         677      687      +10     
  Branches       39       41       +2     
==========================================
+ Hits          520      533      +13     
+ Misses        131      127       -4     
- Partials       26       27       +1     
Files Coverage Δ
src/HttpHandler/Fetch.fs 91.66% <ø> (ø)
src/HttpHandler/HttpContext.fs 88.00% <100.00%> (+0.32%) ⬆️
src/HttpHandler/Logging.fs 94.80% <88.88%> (+4.95%) ⬆️

Copy link
Contributor

@dbrattli dbrattli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice addition! Thanks for the contribution!

@dbrattli dbrattli merged commit bcae57b into master Nov 8, 2023
3 checks passed
@dbrattli dbrattli deleted the response-header-logging branch November 8, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants