Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add case-insensitive fallback for response header logging #150

Merged
merged 5 commits into from
May 16, 2024

Conversation

ozangoktan
Copy link
Contributor

@ozangoktan ozangoktan commented May 16, 2024

Adds a fallback case-insensitive mode of response header logging. It is slower than matching by exact string, as we have to process response headers, but we only do that if the exact string match fails.

Enforces response header logging keys to be case-insensitive as per the standard.

@ozangoktan ozangoktan requested a review from a team as a code owner May 16, 2024 10:31
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.54%. Comparing base (44def6b) to head (aff04d8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   77.29%   77.54%   +0.24%     
==========================================
  Files           9        9              
  Lines         674      677       +3     
  Branches       40       38       -2     
==========================================
+ Hits          521      525       +4     
  Misses        126      126              
+ Partials       27       26       -1     
Files Coverage Δ
src/Logging.fs 96.47% <100.00%> (+1.34%) ⬆️

src/Logging.fs Outdated Show resolved Hide resolved
Co-authored-by: Dag Brattli <dag.brattli@cognite.com>
@ozangoktan ozangoktan requested a review from dbrattli May 16, 2024 11:54
@ozangoktan ozangoktan merged commit 8e7ce8e into master May 16, 2024
5 checks passed
@ozangoktan ozangoktan deleted the case-insensitive-response-header-logging branch May 16, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants