Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test / fix for lpdot #769

Merged
merged 2 commits into from
Aug 31, 2024
Merged

add test / fix for lpdot #769

merged 2 commits into from
Aug 31, 2024

Conversation

frrad
Copy link
Contributor

@frrad frrad commented Aug 21, 2024

Without the change to lpdot, this new test fails with

E       AssertionError: assert [{'name': 'x', 'value': 1}] == [{'name': 'x', 'value': 2}]
E         
E         At index 0 diff: {'name': 'x', 'value': 1} != {'name': 'x', 'value': 2}
E         Use -v to get more diff

The lpdot function uses isiterable to check for "vector" types, however an LpAffineExpression is iterable.

@CLAassistant
Copy link

CLAassistant commented Aug 21, 2024

CLA assistant check
All committers have signed the CLA.

@frrad
Copy link
Contributor Author

frrad commented Aug 22, 2024

I did a bit more looking around and found #572 and #483 for the same issue :-/

Just wanted to flag so that when you eventually take one of them you can close the other.

@pchtsp pchtsp merged commit b5a445f into coin-or:master Aug 31, 2024
18 checks passed
@frrad
Copy link
Contributor Author

frrad commented Aug 31, 2024

Thanks!

@frrad frrad deleted the fred/lpdot branch August 31, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants