Support for importing prefunded accounts #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3870
💛 - Coveralls |
added 3 commits
August 17, 2020 12:19
1 task
patrick-ogrady
approved these changes
Aug 17, 2020
| @@ -136,6 +136,13 @@ func InitializeConstruction( | |||
| fetcher.WithTimeout(time.Duration(config.HTTPTimeout)*time.Second), | |||
| ) | |||
|
|
|||
| // Import prefunded account and save to database | |||
| // TODO: load balances of these imported addresses | |||
There was a problem hiding this comment.
nit: load balances and coins of imported addresses
patrick-ogrady
suggested changes
Aug 17, 2020
pkg/storage/key_storage.go
Outdated
| // Skip if key already exists | ||
| err = k.Store(ctx, acc.Address, keyPair) | ||
| if err != nil { | ||
| alreadyExists := strings.Contains(err.Error(), "already exists") |
There was a problem hiding this comment.
nit: let's use errors.Is here
patrick-ogrady
approved these changes
Aug 17, 2020
patrick-ogrady
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Supports importing accounts into the database by adding them as
PrefundedAccountin the config file.Solution
Open questions