From 75ae3de7c17b8dd9fc1c271ff53d62414cff7fc5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9o=20Galley?= Date: Thu, 15 Aug 2024 10:27:30 -0400 Subject: [PATCH 1/3] add min height/width and object fit cover to avatar --- src/identity/components/Avatar.stories.tsx | 2 +- src/identity/components/Avatar.tsx | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/identity/components/Avatar.stories.tsx b/src/identity/components/Avatar.stories.tsx index ad99d4d98a..2b08731f3c 100644 --- a/src/identity/components/Avatar.stories.tsx +++ b/src/identity/components/Avatar.stories.tsx @@ -73,7 +73,7 @@ export const WithBadge: Story = { export const Base: Story = { args: { - address: '0xFd3d8ffE248173B710b4e24a7E75ac4424853503', + address: '0x8c8F1a1e1bFdb15E7ed562efc84e5A588E68aD73', chain: base, }, }; diff --git a/src/identity/components/Avatar.tsx b/src/identity/components/Avatar.tsx index a7431bef6b..de2dc1d11c 100644 --- a/src/identity/components/Avatar.tsx +++ b/src/identity/components/Avatar.tsx @@ -74,6 +74,7 @@ export function Avatar({ {/* biome-ignore lint: alt gets assigned */} {displayAvatarImg ? ( Date: Thu, 15 Aug 2024 10:29:52 -0400 Subject: [PATCH 2/3] changeset --- .changeset/afraid-tips-whisper.md | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 .changeset/afraid-tips-whisper.md diff --git a/.changeset/afraid-tips-whisper.md b/.changeset/afraid-tips-whisper.md new file mode 100644 index 0000000000..d8c5571e60 --- /dev/null +++ b/.changeset/afraid-tips-whisper.md @@ -0,0 +1,4 @@ +--- +"@coinbase/onchainkit": minor +--- +**fix**: Modify `Avatar` component to handle images with varying height/width ratio. By @kirkas #1058 \ No newline at end of file From d6629e541e4251b75a60bb4bf2b7171070d3b7f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9o=20Galley?= Date: Thu, 15 Aug 2024 12:28:04 -0400 Subject: [PATCH 3/3] lint --- src/identity/components/Avatar.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/identity/components/Avatar.tsx b/src/identity/components/Avatar.tsx index de2dc1d11c..555a7ac2c0 100644 --- a/src/identity/components/Avatar.tsx +++ b/src/identity/components/Avatar.tsx @@ -74,7 +74,7 @@ export function Avatar({ {/* biome-ignore lint: alt gets assigned */} {displayAvatarImg ? (