Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

works for binary uuids #1

Merged
merged 29 commits into from
Dec 15, 2023
Merged

works for binary uuids #1

merged 29 commits into from
Dec 15, 2023

Conversation

ondramie
Copy link
Collaborator

@ondramie ondramie commented Dec 12, 2023 •
edited
Loading

Runs to completion locally for String_UUID and BINARY

Related Issues:

  1. Support UUID x Text comparison datafold/data-diff#513
  2. @ in redshift password datafold/data-diff#428

TODOS

  1. pass unit tests locally
  2. ADD ECR to coinlist
  3. ADD ci-cd

@ondramie ondramie self-assigned this Dec 12, 2023
@ondramie ondramie changed the title works for binary uuids works for binary uuids DATA-1308 Dec 13, 2023
@ondramie ondramie changed the title works for binary uuids DATA-1308 works for binary uuids Dec 13, 2023
@ondramie ondramie marked this pull request as ready for review December 15, 2023 08:15
@ondramie ondramie merged commit b68de1f into master Dec 15, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattDelac MattDelac Awaiting requested review from MattDelac

Assignees

@ondramie ondramie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ondramie