Sovrn: Pass the imp.ext.deals field (prebid#6098)

* EX-2549 Pass segments parameter as imp.ext.dealids array * EX-2549 Address Jon's feedback * EX-2549 Reworked the solution * EX-2549 Blackbird compatibility * EX-2549 Address Jon's comments * EX-2549 Addressed upstream PR comments
cointraffic · May 28, 2021 · 0ca7e7d · 0ca7e7d
1 parent d8ab59c
commit 0ca7e7d
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 2 deletions.
diff --git a/modules/sovrnBidAdapter.js b/modules/sovrnBidAdapter.js
@@ -53,7 +53,7 @@ export const spec = {
         bidSizes = ((utils.isArray(bidSizes) && utils.isArray(bidSizes[0])) ? bidSizes : [bidSizes])
         bidSizes = bidSizes.filter(size => utils.isArray(size))
         const processedSizes = bidSizes.map(size => ({w: parseInt(size[0], 10), h: parseInt(size[1], 10)}))
-        sovrnImps.push({
+        const imp = {
           adunitcode: bid.adUnitCode,
           id: bid.bidId,
           banner: {
@@ -63,7 +63,17 @@ export const spec = {
           },
           tagid: String(utils.getBidIdParameter('tagid', bid.params)),
           bidfloor: utils.getBidIdParameter('bidfloor', bid.params)
-        });
+        }
+
+        const segmentsString = utils.getBidIdParameter('segments', bid.params)
+
+        if (segmentsString) {
+          imp.ext = {
+            deals: segmentsString.split(',').map(deal => deal.trim())
+          }
+        }
+
+        sovrnImps.push(imp);
       });
 
       const page = bidderRequest.refererInfo.referer

diff --git a/test/spec/modules/sovrnBidAdapter_spec.js b/test/spec/modules/sovrnBidAdapter_spec.js
@@ -276,6 +276,32 @@ describe('sovrnBidAdapter', function() {
       expect(data.user.ext.tpid[0].uid).to.equal('A_CRITEO_ID')
       expect(data.user.ext.prebid_criteoid).to.equal('A_CRITEO_ID')
     });
+
+    it('should ignore empty segments', function() {
+      const payload = JSON.parse(request.data)
+      expect(payload.imp[0].ext).to.be.undefined
+    })
+
+    it('should pass the segments param value as trimmed deal ids array', function() {
+      const segmentsRequests = [{
+        'bidder': 'sovrn',
+        'params': {
+          'segments': ' test1,test2 '
+        },
+        'adUnitCode': 'adunit-code',
+        'sizes': [
+          [300, 250],
+          [300, 600]
+        ],
+        'bidId': '30b31c1838de1e',
+        'bidderRequestId': '22edbae2733bf6',
+        'auctionId': '1d1a030790a475'
+      }];
+      const request = spec.buildRequests(segmentsRequests, bidderRequest)
+      const payload = JSON.parse(request.data)
+      expect(payload.imp[0].ext.deals[0]).to.equal('test1')
+      expect(payload.imp[0].ext.deals[1]).to.equal('test2')
+    })
   });
 
   describe('interpretResponse', function () {