Fix return value from CMAKE_MODULE_PATH hook #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a regression introduced by 5704d83 which was hidden by some nuanced API characteristics for environment hook extensions, which would manifest as silently missing environment hooks for CMAKE_MODULE_PATH.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #147 +/- ##
=======================================
Coverage 29.39% 29.39%
=======================================
Files 10 10
Lines 745 745
Branches 165 166 +1
=======================================
Hits 219 219
Misses 484 484
Partials 42 42 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
nuclearsandwich
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a regression introduced by #20 which was hidden by some nuanced API characteristics for environment hook extensions, which would manifest as silently missing environment hooks for CMAKE_MODULE_PATH.