Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port environment hook tests from colcon_core #148

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Nov 22, 2024

Requires #147

@cottsay cottsay added the bug Something isn't working label Nov 22, 2024
@cottsay cottsay added this to the 0.2.29 milestone Nov 22, 2024
@cottsay cottsay self-assigned this Nov 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.00%. Comparing base (8a69a89) to head (0c6c6ea).
Report is 1 commits behind head on cottsay/cmake-module-path-fix.

Additional details and impacted files
@@                        Coverage Diff                        @@
##           cottsay/cmake-module-path-fix     #148      +/-   ##
=================================================================
+ Coverage                          29.39%   31.00%   +1.61%     
=================================================================
  Files                                 10       10              
  Lines                                745      745              
  Branches                             165      166       +1     
=================================================================
+ Hits                                 219      231      +12     
+ Misses                               484      475       -9     
+ Partials                              42       39       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing and approving based on prior approval of the needed PR.

Base automatically changed from cottsay/cmake-module-path-fix to master November 22, 2024 19:33
@cottsay cottsay marked this pull request as ready for review November 22, 2024 19:34
@cottsay cottsay merged commit e2e679a into master Nov 22, 2024
17 checks passed
@cottsay cottsay deleted the cottsay/tests-environment-hooks branch November 22, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants