From 561329f666c3908c9f129c6d5b00b6b8f95091b9 Mon Sep 17 00:00:00 2001
From: KarinG <karin@semper-it.com>
Date: Sun, 29 Sep 2024 14:04:42 -0600
Subject: [PATCH 1/5] Add pngs to debug AJAX error in
 testSubmitMembershipQueryParams

---
 .../FunctionalJavascript/MembershipSubmissionTest.php  | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/tests/src/FunctionalJavascript/MembershipSubmissionTest.php b/tests/src/FunctionalJavascript/MembershipSubmissionTest.php
index 80ed86b95..c5bc6be69 100644
--- a/tests/src/FunctionalJavascript/MembershipSubmissionTest.php
+++ b/tests/src/FunctionalJavascript/MembershipSubmissionTest.php
@@ -210,25 +210,34 @@ public function testSubmitMembershipQueryParams() {
     // Add the Default -> [current-page:query:membership]
     $membershipElementEdit = $this->assertSession()->elementExists('css', '[data-drupal-selector="edit-webform-ui-elements-civicrm-1-membership-1-membership-membership-type-id-operations"] a.webform-ajax-link');
     $membershipElementEdit->click();
+    $this->createScreenshot($this->htmlOutputDirectory . '/debug01.png');
     $this->assertSession()->assertWaitOnAjaxRequest();
+    $this->createScreenshot($this->htmlOutputDirectory . '/debug02.png');
     $this->getSession()->getPage()->checkField('properties[extra][aslist]');
     $this->assertSession()->checkboxChecked('properties[extra][aslist]');
+    $this->createScreenshot($this->htmlOutputDirectory . '/debug03.png');
 
     $this->htmlOutput();
 
     $this->getSession()->getPage()->clickLink('Advanced');
     $this->assertSession()->assertWaitOnAjaxRequest();
     $this->htmlOutput();
+    $this->createScreenshot($this->htmlOutputDirectory . '/debug04.png');
+
     $fieldset = $this->assertSession()->elementExists('css', '[data-drupal-selector="edit-default"]');
     $fieldset->click();
     $this->getSession()->getPage()->fillField('Default value', '[current-page:query:membership]');
+    $this->createScreenshot($this->htmlOutputDirectory . '/debug05.png');
+
     $this->getSession()->getPage()->pressButton('Save');
+    $this->createScreenshot($this->htmlOutputDirectory . '/debug06.png');
 
     $this->drupalLogout();
     $this->drupalGet($this->webform->toUrl('canonical', ['query' => ['membership' => 2]]));
     $this->htmlOutput();
     // ToDo ->
     $this->assertPageNoErrorMessages();
+    $this->createScreenshot($this->htmlOutputDirectory . '/debug07.png');
 
     $this->assertSession()->waitForField('First Name');
     $this->getSession()->getPage()->fillField('First Name', 'Frederick');
@@ -238,6 +247,7 @@ public function testSubmitMembershipQueryParams() {
     $this->htmlOutput();
     // ToDo ->
     $this->assertPageNoErrorMessages();
+    $this->createScreenshot($this->htmlOutputDirectory . '/debug08.png');
 
     $this->assertSession()->pageTextContains('New submission added to CiviCRM Webform Test.');
 

From 7773aafedf4757d063b01932505b22c2f609e5bc Mon Sep 17 00:00:00 2001
From: KarinG <karin@semper-it.com>
Date: Sun, 29 Sep 2024 14:08:29 -0600
Subject: [PATCH 2/5] Also log errors

---
 .../src/FunctionalJavascript/MembershipSubmissionTest.php  | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/src/FunctionalJavascript/MembershipSubmissionTest.php b/tests/src/FunctionalJavascript/MembershipSubmissionTest.php
index c5bc6be69..af8e052bd 100644
--- a/tests/src/FunctionalJavascript/MembershipSubmissionTest.php
+++ b/tests/src/FunctionalJavascript/MembershipSubmissionTest.php
@@ -243,14 +243,19 @@ public function testSubmitMembershipQueryParams() {
     $this->getSession()->getPage()->fillField('First Name', 'Frederick');
     $this->getSession()->getPage()->fillField('Last Name', 'Pabst');
     $this->assertSession()->pageTextContains('Basic Plus');
+    \CRM_Core_Error::debug_log_message('here 1');
     $this->getSession()->getPage()->pressButton('Submit');
+    \CRM_Core_Error::debug_log_message('here 2');
     $this->htmlOutput();
     // ToDo ->
+    \CRM_Core_Error::debug_log_message('here 3');
     $this->assertPageNoErrorMessages();
+    \CRM_Core_Error::debug_log_message('here 4');
     $this->createScreenshot($this->htmlOutputDirectory . '/debug08.png');
 
     $this->assertSession()->pageTextContains('New submission added to CiviCRM Webform Test.');
-
+    \CRM_Core_Error::debug_log_message('here 5');
+    
     $api_result = $this->utils->wf_civicrm_api('membership', 'get', [
       'sequential' => 1,
     ]);

From 55ffc7e6af2a9bf5378d834c1107129580f9bcd5 Mon Sep 17 00:00:00 2001
From: KarinG <karin@semper-it.com>
Date: Sun, 29 Sep 2024 16:26:19 -0600
Subject: [PATCH 3/5] Update MembershipSubmissionTest.php

---
 tests/src/FunctionalJavascript/MembershipSubmissionTest.php | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/src/FunctionalJavascript/MembershipSubmissionTest.php b/tests/src/FunctionalJavascript/MembershipSubmissionTest.php
index af8e052bd..bbaf356b2 100644
--- a/tests/src/FunctionalJavascript/MembershipSubmissionTest.php
+++ b/tests/src/FunctionalJavascript/MembershipSubmissionTest.php
@@ -231,6 +231,9 @@ public function testSubmitMembershipQueryParams() {
 
     $this->getSession()->getPage()->pressButton('Save');
     $this->createScreenshot($this->htmlOutputDirectory . '/debug06.png');
+    
+    $this->assertSession()->assertWaitOnAjaxRequest();
+    $this->getSession()->getPage()->pressButton('Save elements');
 
     $this->drupalLogout();
     $this->drupalGet($this->webform->toUrl('canonical', ['query' => ['membership' => 2]]));

From 9602a2378952a37ec340e9fa2ddc520bf1768b28 Mon Sep 17 00:00:00 2001
From: KarinG <karin@semper-it.com>
Date: Sun, 29 Sep 2024 18:34:56 -0600
Subject: [PATCH 4/5] Update MembershipSubmissionTest.php

---
 .../MembershipSubmissionTest.php                   | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/tests/src/FunctionalJavascript/MembershipSubmissionTest.php b/tests/src/FunctionalJavascript/MembershipSubmissionTest.php
index bbaf356b2..37dc5f060 100644
--- a/tests/src/FunctionalJavascript/MembershipSubmissionTest.php
+++ b/tests/src/FunctionalJavascript/MembershipSubmissionTest.php
@@ -210,27 +210,21 @@ public function testSubmitMembershipQueryParams() {
     // Add the Default -> [current-page:query:membership]
     $membershipElementEdit = $this->assertSession()->elementExists('css', '[data-drupal-selector="edit-webform-ui-elements-civicrm-1-membership-1-membership-membership-type-id-operations"] a.webform-ajax-link');
     $membershipElementEdit->click();
-    $this->createScreenshot($this->htmlOutputDirectory . '/debug01.png');
     $this->assertSession()->assertWaitOnAjaxRequest();
-    $this->createScreenshot($this->htmlOutputDirectory . '/debug02.png');
     $this->getSession()->getPage()->checkField('properties[extra][aslist]');
     $this->assertSession()->checkboxChecked('properties[extra][aslist]');
-    $this->createScreenshot($this->htmlOutputDirectory . '/debug03.png');
 
     $this->htmlOutput();
 
     $this->getSession()->getPage()->clickLink('Advanced');
     $this->assertSession()->assertWaitOnAjaxRequest();
     $this->htmlOutput();
-    $this->createScreenshot($this->htmlOutputDirectory . '/debug04.png');
 
     $fieldset = $this->assertSession()->elementExists('css', '[data-drupal-selector="edit-default"]');
     $fieldset->click();
     $this->getSession()->getPage()->fillField('Default value', '[current-page:query:membership]');
-    $this->createScreenshot($this->htmlOutputDirectory . '/debug05.png');
 
     $this->getSession()->getPage()->pressButton('Save');
-    $this->createScreenshot($this->htmlOutputDirectory . '/debug06.png');
     
     $this->assertSession()->assertWaitOnAjaxRequest();
     $this->getSession()->getPage()->pressButton('Save elements');
@@ -240,24 +234,16 @@ public function testSubmitMembershipQueryParams() {
     $this->htmlOutput();
     // ToDo ->
     $this->assertPageNoErrorMessages();
-    $this->createScreenshot($this->htmlOutputDirectory . '/debug07.png');
 
     $this->assertSession()->waitForField('First Name');
     $this->getSession()->getPage()->fillField('First Name', 'Frederick');
     $this->getSession()->getPage()->fillField('Last Name', 'Pabst');
     $this->assertSession()->pageTextContains('Basic Plus');
-    \CRM_Core_Error::debug_log_message('here 1');
     $this->getSession()->getPage()->pressButton('Submit');
-    \CRM_Core_Error::debug_log_message('here 2');
     $this->htmlOutput();
-    // ToDo ->
-    \CRM_Core_Error::debug_log_message('here 3');
     $this->assertPageNoErrorMessages();
-    \CRM_Core_Error::debug_log_message('here 4');
-    $this->createScreenshot($this->htmlOutputDirectory . '/debug08.png');
 
     $this->assertSession()->pageTextContains('New submission added to CiviCRM Webform Test.');
-    \CRM_Core_Error::debug_log_message('here 5');
     
     $api_result = $this->utils->wf_civicrm_api('membership', 'get', [
       'sequential' => 1,

From e344734d9ff6200467cd4a6bc25cfd6ae4eacb98 Mon Sep 17 00:00:00 2001
From: KarinG <karin@semper-it.com>
Date: Sun, 29 Sep 2024 18:40:09 -0600
Subject: [PATCH 5/5] Update MembershipSubmissionTest.php

---
 .../src/FunctionalJavascript/MembershipSubmissionTest.php  | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/tests/src/FunctionalJavascript/MembershipSubmissionTest.php b/tests/src/FunctionalJavascript/MembershipSubmissionTest.php
index 37dc5f060..2427e8ece 100644
--- a/tests/src/FunctionalJavascript/MembershipSubmissionTest.php
+++ b/tests/src/FunctionalJavascript/MembershipSubmissionTest.php
@@ -219,20 +219,17 @@ public function testSubmitMembershipQueryParams() {
     $this->getSession()->getPage()->clickLink('Advanced');
     $this->assertSession()->assertWaitOnAjaxRequest();
     $this->htmlOutput();
-
     $fieldset = $this->assertSession()->elementExists('css', '[data-drupal-selector="edit-default"]');
     $fieldset->click();
     $this->getSession()->getPage()->fillField('Default value', '[current-page:query:membership]');
-
     $this->getSession()->getPage()->pressButton('Save');
-    
     $this->assertSession()->assertWaitOnAjaxRequest();
+    
     $this->getSession()->getPage()->pressButton('Save elements');
 
     $this->drupalLogout();
     $this->drupalGet($this->webform->toUrl('canonical', ['query' => ['membership' => 2]]));
     $this->htmlOutput();
-    // ToDo ->
     $this->assertPageNoErrorMessages();
 
     $this->assertSession()->waitForField('First Name');
@@ -244,7 +241,7 @@ public function testSubmitMembershipQueryParams() {
     $this->assertPageNoErrorMessages();
 
     $this->assertSession()->pageTextContains('New submission added to CiviCRM Webform Test.');
-    
+
     $api_result = $this->utils->wf_civicrm_api('membership', 'get', [
       'sequential' => 1,
     ]);