bump mapper version to fix zeitwerk problem #170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zeitwerk:check
(as per statement from zeitwerk maintainer)CollectionSpace::Mapper::DataHandler
with a client-less RefCachecsid_cache
parameter to constructor forCollectionSpace::Mapper::DataHandler
-- Since the only way to search for relations is by subject/object CSID, we need a way to efficiently look up CSIDs. Since I'm already setting upcollectionspace-mapper
to work with two separateCollectionSpace::RefCache
instances for migration tooling stuff---one for refnames for terms, and one for CSIDs---it is much more straightforward to just make it always use two separate RefCaches for these two separate types of information. WhenCollectionSpace::Mapper
is used with the default batch config bycollectionspace-csv-importer
, the CSID RefCache will only be used for looking up CSIDs to use in constructing searches for relations (required to determine the status of a given relation in the system).