Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timezones and add support for pydantic 1.9.0 #508

Merged
merged 13 commits into from
Jan 14, 2022

Conversation

collerek
Copy link
Owner

@collerek collerek commented Jan 6, 2022

0.10.24

✨ Features

🐛 Fixes

💬 Other

  • Improve performance of bulk_create by bypassing databases execute_many suboptimal implementation. (by @Mng-dev-ai thanks!) #520
  • Bump min. required databases version for sqlalchemy 1.4 to >=5.4.

@collerek collerek added the waiting for release New functionality waiting for future release label Jan 6, 2022
@Goldziher
Copy link

@collerek - I suggest you consider also adding python 3.10 support and dropping python 3.6.

@collerek
Copy link
Owner Author

collerek commented Jan 7, 2022

@Goldziher I wanted to do this some time ago but I think databases still don't support python 3.10 so I'm blocked.

@Goldziher
Copy link

Are you sure this is a blocker? 3.10 probably doesn't break anything, but it will give a new syntax for those who use it. I suggest updating the test matrix and seeing.

@collerek
Copy link
Owner Author

collerek commented Jan 7, 2022

Are you sure this is a blocker? 3.10 probably doesn't break anything, but it will give a new syntax for those who use it. I suggest updating the test matrix and seeing.

Ok it was aiomysql at that time not databases: https://github.com/collerek/ormar/runs/4141248426?check_suite_focus=true.
Can check if it works now.

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

Merging #508 (b208e88) into master (433d450) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #508   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          185       185           
  Lines        15253     15285   +32     
=========================================
+ Hits         15253     15285   +32     
Impacted Files Coverage Δ
ormar/exceptions.py 100.00% <ø> (ø)
ormar/fields/model_fields.py 100.00% <ø> (ø)
ormar/models/newbasemodel.py 100.00% <ø> (ø)
ormar/queryset/query.py 100.00% <ø> (ø)
ormar/signals/signal.py 100.00% <ø> (ø)
...ests/test_queries/test_nested_reverse_relations.py 100.00% <ø> (ø)
ormar/decorators/signals.py 100.00% <100.00%> (ø)
ormar/models/helpers/validation.py 100.00% <100.00%> (ø)
ormar/models/mixins/save_mixin.py 100.00% <100.00%> (ø)
ormar/queryset/actions/filter_action.py 100.00% <100.00%> (ø)
... and 9 more

@collerek collerek merged commit 6ec4825 into master Jan 14, 2022
@collerek collerek deleted the check_timezones_filters branch January 14, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for release New functionality waiting for future release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants