-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deltas()
function, closes #437
#532
Conversation
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Shouldn't this have special handling for hues? |
Yes, as I said earlier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to calculate delta of the hue arc, not the angular delta
I envisioned this as a low-level utility function, if users want to make this optimization for hue it's trivial to do so on the deltas returned. That said, it should definitely constrain the ΔH returned in some way (possibly by also preserving the original). We shouldn't have a color with a hue of 350 and a color with a hue of 0 appear to have a ΔΗ of 350. It seems like this could follow shorter hue, possibly even take an argument for it. |
- `hue` option to customize how hues are handled - `shorter` by default
Ok, I’ve made several improvements:
|
We could have another option for scaling the Δh by taking C/L into account, but not sure how that would work in a generic way. |
Looks good to me. I would fix lint issues. related to the files in questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.