Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies on deprecated scalajs-dom stuff #198

Open
bwbecker opened this issue Mar 19, 2020 · 2 comments
Open

Dependencies on deprecated scalajs-dom stuff #198

bwbecker opened this issue Mar 19, 2020 · 2 comments

Comments

@bwbecker
Copy link

I'm using the latest version of scalatags on Maven (0.8.6). If I use the latest version of scalajs-dom (1.0.0) or even 0.9.8 I get a compile error:

[error] /Users/bwbecker/oat/src/oat3/modules/browser/src/main/scala/oat/browser/views/components/filteredTable/FilteredUsersTable.scala:123:7: Symbol 'type org.scalajs.dom.html.TableHeaderCell' is missing from the classpath.
[error] This symbol is required by 'lazy value scalatags.jsdom.Tags.th'.
[error] Make sure that type TableHeaderCell is in your classpath and check for conflicting dependencies with `-Ylog-classpath`.
[error] A full rebuild may help if 'Tags.class' was compiled against an incompatible version of org.scalajs.dom.html.
[error]       th("Userid"),
[error]       ^

The definition of th is

  lazy val th = typedTag[dom.html.TableHeaderCell]("th")

and in the Feb 7, 2020 commit of scalajs-dom in src/main/scala/org/scalajs/dom/html.scala we have the following code removed:

  @deprecated(
      "https://developer.mozilla.org/en-US/docs/Web/API/HTMLTableHeaderCellElement",
      "0.9.8")
  type TableHeaderCell = raw.HTMLTableHeaderCellElement
@ddworak
Copy link
Contributor

ddworak commented Apr 3, 2020

+1, this blocked the upgrade for us in udash-core UdashFramework/udash-core#529

@sake92
Copy link
Contributor

sake92 commented Sep 23, 2020

Fixed in #201 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants