Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sporadic failure on test_permission_request_notifications_flow_for_manual_review #3704

Closed
chrisvanrun opened this issue Nov 19, 2024 · 1 comment · Fixed by #3707
Closed
Assignees
Labels

Comments

@chrisvanrun
Copy link
Contributor

See run: https://github.com/comic/grand-challenge.org/actions/runs/11909994990/job/33188499636

I think it is quickly fixable by ordering the notifications.

@jmsmkn
Copy link
Member

jmsmkn commented Nov 19, 2024

Quick fix: you can mark the test as flaky using @pytest.mark.flaky(reruns=3). Proper fix: rewrite the test so that it is not dependent on the ordering of Notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants